You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by steveblackmon <gi...@git.apache.org> on 2014/11/12 02:48:06 UTC
[GitHub] incubator-streams pull request: refresh streams-config
GitHub user steveblackmon opened a pull request:
https://github.com/apache/incubator-streams/pull/126
refresh streams-config
support detection of StreamsConfiguration
support detection of any component configuration
test using base ComponentConfiguration
new tasks coming to refactor existing modules
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-streams STREAMS-215
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #126
----
commit 13024d00309b9576ff5cb6fe49beccbd33062228
Author: sblackmon <sb...@apache.org>
Date: 2014-11-11T23:44:59Z
refresh streams-config
support detection of StreamsConfiguration
support detection of any component configuration
test using base ComponentConfiguration
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: refresh streams-config
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on the pull request:
https://github.com/apache/incubator-streams/pull/126#issuecomment-63370372
latest push addresses all feedback and adds two tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: refresh streams-config
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/126#discussion_r20368968
--- Diff: streams-config/src/main/java/org/apache/streams/config/StreamsConfigurator.java ---
@@ -18,8 +18,15 @@
package org.apache.streams.config;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.google.common.reflect.TypeToken;
import com.typesafe.config.Config;
import com.typesafe.config.ConfigFactory;
+import com.typesafe.config.ConfigRenderOptions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Serializable;
/**
* Created with IntelliJ IDEA.
--- End diff --
Since you are in this file anyway, now would be a good time to replace current doc with functional documentation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: refresh streams-config
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/126#discussion_r20368889
--- Diff: streams-config/src/main/java/org/apache/streams/config/ComponentConfigurator.java ---
@@ -0,0 +1,47 @@
+package org.apache.streams.config;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.google.common.reflect.TypeToken;
+import com.typesafe.config.Config;
+import com.typesafe.config.ConfigRenderOptions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Serializable;
+
+/**
+ * Created by sblackmon on 11/11/14.
--- End diff --
s/name/Functional documentation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: refresh streams-config
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/126#discussion_r20369274
--- Diff: streams-config/src/test/java/org/apache/streams/config/test/ComponentConfiguratorTest.java ---
@@ -0,0 +1,37 @@
+package org.apache.streams.config.test;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.typesafe.config.Config;
+import com.typesafe.config.ConfigFactory;
+import junit.framework.Assert;
+import org.apache.streams.config.ComponentConfiguration;
+import org.apache.streams.config.ComponentConfigurator;
+import org.apache.streams.config.StreamsConfigurator;
+import org.junit.Test;
+
+/**
+ * Created by sblackmon on 10/20/14.
--- End diff --
Doc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: refresh streams-config
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/126#discussion_r20368875
--- Diff: streams-config/src/main/java/org/apache/streams/config/ComponentConfigurator.java ---
@@ -0,0 +1,47 @@
+package org.apache.streams.config;
--- End diff --
License header
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: refresh streams-config
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/126#discussion_r20369286
--- Diff: streams-config/src/test/java/org/apache/streams/config/test/StreamsConfiguratorTest.java ---
@@ -0,0 +1,48 @@
+package org.apache.streams.config.test;
--- End diff --
License header
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: refresh streams-config
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: refresh streams-config
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/126#discussion_r20369262
--- Diff: streams-config/src/test/java/org/apache/streams/config/test/ComponentConfiguratorTest.java ---
@@ -0,0 +1,37 @@
+package org.apache.streams.config.test;
--- End diff --
License header
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---