You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "flyrain (via GitHub)" <gi...@apache.org> on 2025/10/28 16:34:42 UTC
[PR] Site: Rename menu "downloads" to "releases" [polaris]
flyrain opened a new pull request, #2928:
URL: https://github.com/apache/polaris/pull/2928
We have discussed the renaming of the "downloads" page to "releases". Here is the PR.
### How was this patch tested?
Test locally, the new menu "releases" works well. Cannot test versioned doc locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site: Rename menu "downloads" to "releases" [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain merged PR #2928:
URL: https://github.com/apache/polaris/pull/2928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site: Rename menu "downloads" to "releases" [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #2928:
URL: https://github.com/apache/polaris/pull/2928#issuecomment-3457599219
> Cannot test versioned doc locally.
* clone polaris
* cd site/content/
* git clone --reference ../../polaris git@github.com:apache/polaris.git releases
* cd releases
* git co versioned-docs
* cd ../../..
* site/bin/run-hugo-in-docker.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site: Rename menu "downloads" to "releases" [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #2928:
URL: https://github.com/apache/polaris/pull/2928#discussion_r2470274684
##########
site/hugo.yaml:
##########
@@ -97,37 +97,37 @@ imaging:
menu:
main:
- name: "Documentation"
- identifier: "releases"
+ identifier: "doc"
weight: 100
params:
orderby: weight.desc
- name: "In Development"
url: "/in-dev/unreleased/"
- parent: "releases"
+ parent: "doc"
weight: 1
- name: "1.2.0"
url: "/releases/1.2.0/"
- parent: "releases"
+ parent: "doc"
weight: 996
- name: "1.1.0"
url: "/releases/1.1.0/"
- parent: "releases"
+ parent: "doc"
weight: 997
- name: "1.0.1"
url: "/releases/1.0.1/"
- parent: "releases"
+ parent: "doc"
weight: 998
- name: "1.0.0"
url: "/releases/1.0.0/"
- parent: "releases"
+ parent: "doc"
weight: 999
- name: "0.9.0"
url: "/releases/0.9.0/"
- parent: "releases"
+ parent: "doc"
weight: 1000
- - name: "Downloads"
- identifier: "downloads"
+ - name: "Releases"
+ identifier: "releases"
url: "/downloads"
Review Comment:
Trying to keep it for backward compatibilities, as we've shared the link multiple places. I'm OK to change it to `releases` as well if people think consistency is more important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site: Rename menu "downloads" to "releases" [polaris]
Posted by "singhpk234 (via GitHub)" <gi...@apache.org>.
singhpk234 commented on PR #2928:
URL: https://github.com/apache/polaris/pull/2928#issuecomment-3457715977
+1 for this rename ! Here is a nice data showing how people coming to download page in our website `polaris.apache.org` eventually land to releases page
https://analytics.apache.org/index.php?module=CoreHome&action=index&date=yesterday&period=day&idSite=81#?period=week&date=2025-10-27&idSite=81&category=General_Actions&subcategory=Transitions_Transitions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site: Rename menu "downloads" to "releases" [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #2928:
URL: https://github.com/apache/polaris/pull/2928#issuecomment-3527091139
> We should probably consider breaking it up before it just becomes one really long page, but that's out of scope for this PR
Related to this,I've created #3039 to illustrate this and other things related to "many releases".
But TL;DR splitting up this page is one bullet point on the list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site: Rename menu "downloads" to "releases" [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #2928:
URL: https://github.com/apache/polaris/pull/2928#issuecomment-3480273722
Also cannot find a discussion on the mailing list for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site: Rename menu "downloads" to "releases" [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #2928:
URL: https://github.com/apache/polaris/pull/2928#issuecomment-3457455013
@flyrain :
> We have discussed the renaming of the "downloads" page to "releases".
Could you link the discussion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site: Rename menu "downloads" to "releases" [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on PR #2928:
URL: https://github.com/apache/polaris/pull/2928#issuecomment-3457557130
> Could you link the discussion?
Cannot find it :-(. I think @jbonofre was part of the conversation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site: Rename menu "downloads" to "releases" [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #2928:
URL: https://github.com/apache/polaris/pull/2928#issuecomment-3457584845
Yes I confirm we got a discussion about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site: Rename menu "downloads" to "releases" [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #2928:
URL: https://github.com/apache/polaris/pull/2928#issuecomment-3480301989
Yeah, I don't find it either, but I'm sure we discussed about that (during the 0.9.0-incubating prep as far as I remember).
As we don't find the thread, maybe worth to point this PR on the mailing list to have a broader information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org