You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Max Starets (Created) (JIRA)" <de...@myfaces.apache.org> on 2012/02/16 23:55:02 UTC
[jira] [Created] (TRINIDAD-2218) Need an ability for the
WindowManager implementation to be executed before all Configurators and
filters and to complete teh response
Need an ability for the WindowManager implementation to be executed before all Configurators and filters and to complete teh response
-------------------------------------------------------------------------------------------------------------------------------------
Key: TRINIDAD-2218
URL: https://issues.apache.org/jira/browse/TRINIDAD-2218
Project: MyFaces Trinidad
Issue Type: Bug
Affects Versions: 2.0.2-core
Reporter: Max Starets
Assignee: Max Starets
Since WindowManager is expected to make the Window Map available to all Configurators, we need a way to ensure that it is executed before all Configurators and filters. Also, WindowManager needs to be able to complete a response, so that it can send a script response to the client.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TRINIDAD-2218) Need an ability for the
WindowManager implementation to be executed before all Configurators and
filters and to complete teh response
Posted by "Max Starets (Updated) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Max Starets updated TRINIDAD-2218:
----------------------------------
Resolution: Fixed
Fix Version/s: 2.0.2-core
Status: Resolved (was: Patch Available)
> Need an ability for the WindowManager implementation to be executed before all Configurators and filters and to complete teh response
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-2218
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2218
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 2.0.2-core
> Reporter: Max Starets
> Assignee: Max Starets
> Fix For: 2.0.2-core
>
> Attachments: trinidad-2218.patch
>
>
> Since WindowManager is expected to make the Window Map available to all Configurators, we need a way to ensure that it is executed before all Configurators and filters. Also, WindowManager needs to be able to complete a response, so that it can send a script response to the client.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2218) Need an ability for the
WindowManager implementation to be executed before all Configurators and
filters and to complete teh response
Posted by "Scott O'Bryan (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212103#comment-13212103 ]
Scott O'Bryan commented on TRINIDAD-2218:
-----------------------------------------
If I read this correctly, this adds the ability to disable the configurator system if the WindowManager states that the request needs to be aborted. Is there a reason that the disabling code does not use Configurator.disableConfiguratorServices() [http://myfaces.apache.org/trinidad/trinidad-api/apidocs/org/apache/myfaces/trinidad/config/Configurator.html#disableConfiguratorServices%28javax.servlet.ServletRequest%29]. It seems to me that the Trinidad filter might be a more ideal place to handle this to ensure this logic since Configurators cannot prevent execution of the faces lifecycle. Additionally it limits the exposure to portlet environments as the code will not get executed.
> Need an ability for the WindowManager implementation to be executed before all Configurators and filters and to complete teh response
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-2218
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2218
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 2.0.2-core
> Reporter: Max Starets
> Assignee: Scott O'Bryan
> Attachments: trinidad-2218.patch
>
>
> Since WindowManager is expected to make the Window Map available to all Configurators, we need a way to ensure that it is executed before all Configurators and filters. Also, WindowManager needs to be able to complete a response, so that it can send a script response to the client.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2218) Need an ability for the
WindowManager implementation to be executed before all Configurators and
filters and to complete teh response
Posted by "Max Starets (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220959#comment-13220959 ]
Max Starets commented on TRINIDAD-2218:
---------------------------------------
Hey Scott, thanks for reviewing the patch. Configurator.disableConfiguratorServices() did not work because we weren't releasing the RequestContext at the end.
When you say 'Trinidad filter', do you mean TrinidadFilterImpl? The issue is that RequestContext is not available there. If you mean filters invoked after Configurators, then it won't work either because we need to provide a window Id to configurators.
Lets discuss this offline
> Need an ability for the WindowManager implementation to be executed before all Configurators and filters and to complete teh response
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-2218
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2218
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 2.0.2-core
> Reporter: Max Starets
> Assignee: Scott O'Bryan
> Attachments: trinidad-2218.patch
>
>
> Since WindowManager is expected to make the Window Map available to all Configurators, we need a way to ensure that it is executed before all Configurators and filters. Also, WindowManager needs to be able to complete a response, so that it can send a script response to the client.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TRINIDAD-2218) Need an ability for the
WindowManager implementation to be executed before all Configurators and
filters and to complete teh response
Posted by "Max Starets (Updated) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Max Starets updated TRINIDAD-2218:
----------------------------------
Status: Patch Available (was: Open)
> Need an ability for the WindowManager implementation to be executed before all Configurators and filters and to complete teh response
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-2218
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2218
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 2.0.2-core
> Reporter: Max Starets
> Assignee: Max Starets
> Attachments: trinidad-2218.patch
>
>
> Since WindowManager is expected to make the Window Map available to all Configurators, we need a way to ensure that it is executed before all Configurators and filters. Also, WindowManager needs to be able to complete a response, so that it can send a script response to the client.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira