You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by fe...@apache.org on 2010/05/19 15:17:00 UTC
svn commit: r946175 - in
/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap:
filter/ message/ schema/comparators/ schema/normalizers/
Author: felixk
Date: Wed May 19 13:17:00 2010
New Revision: 946175
URL: http://svn.apache.org/viewvc?rev=946175&view=rev
Log:
Remove methods overriding super but just calling super
Modified:
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/AndNode.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/ApproximateNode.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/EqualityNode.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/GreaterEqNode.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/LeafNode.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/LessEqNode.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/NotNode.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/OrNode.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/PresenceNode.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/ScopeNode.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/SimpleNode.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/message/AbstractAbandonableRequest.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/comparators/DeepTrimToLowerCachingNormalizingComparator.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/normalizers/CachingDeepTrimNormalizer.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/normalizers/CachingDeepTrimToLowerNormalizer.java
directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/normalizers/CachingDnNormalizer.java
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/AndNode.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/AndNode.java?rev=946175&r1=946174&r2=946175&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/AndNode.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/AndNode.java Wed May 19 13:17:00 2010
@@ -53,15 +53,6 @@ public class AndNode extends BranchNode
/**
- * Clone the AndNode
- */
- @Override public ExprNode clone()
- {
- return super.clone();
- }
-
-
- /**
* Creates an empty AndNode
*/
public AndNode()
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/ApproximateNode.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/ApproximateNode.java?rev=946175&r1=946174&r2=946175&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/ApproximateNode.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/ApproximateNode.java Wed May 19 13:17:00 2010
@@ -42,15 +42,6 @@ public class ApproximateNode<T> extends
/**
- * Return a cloned node
- */
- @Override public ExprNode clone()
- {
- return super.clone();
- }
-
-
- /**
* @see Object#toString()
* @return A string representing the AndNode
*/
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/EqualityNode.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/EqualityNode.java?rev=946175&r1=946174&r2=946175&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/EqualityNode.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/EqualityNode.java Wed May 19 13:17:00 2010
@@ -43,17 +43,6 @@ public class EqualityNode<T> extends Sim
}
/**
- * Makes a full clone in new memory space of the current node and children
- *
- * @return the clone
- */
- @Override public ExprNode clone()
- {
- return super.clone();
- }
-
-
- /**
* Creates a new Equality object.
*
* @param attribute the attribute name
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/GreaterEqNode.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/GreaterEqNode.java?rev=946175&r1=946174&r2=946175&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/GreaterEqNode.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/GreaterEqNode.java Wed May 19 13:17:00 2010
@@ -43,16 +43,6 @@ public class GreaterEqNode<T> extends Si
}
/**
- * Makes a full clone in new memory space of the current node and children
- *
- * @return the clone
- */
- @Override public ExprNode clone()
- {
- return super.clone();
- }
-
- /**
* @see Object#toString()
* @return A string representing the AndNode
*/
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/LeafNode.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/LeafNode.java?rev=946175&r1=946174&r2=946175&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/LeafNode.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/LeafNode.java Wed May 19 13:17:00 2010
@@ -45,17 +45,6 @@ public class LeafNode extends AbstractEx
}
/**
- * Makes a full clone in new memory space of the current node and children
- *
- * @return the clone
- */
- @Override public ExprNode clone()
- {
- return super.clone();
- }
-
-
- /**
* Gets whether this node is a leaf - the answer is always true here.
*
* @return true always
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/LessEqNode.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/LessEqNode.java?rev=946175&r1=946174&r2=946175&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/LessEqNode.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/LessEqNode.java Wed May 19 13:17:00 2010
@@ -43,16 +43,6 @@ public class LessEqNode<T> extends Simpl
}
/**
- * Makes a full clone in new memory space of the current node and children
- *
- * @return the clone
- */
- @Override public ExprNode clone()
- {
- return super.clone();
- }
-
- /**
* @see Object#toString()
* @return A string representing the AndNode
*/
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/NotNode.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/NotNode.java?rev=946175&r1=946174&r2=946175&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/NotNode.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/NotNode.java Wed May 19 13:17:00 2010
@@ -68,16 +68,6 @@ public class NotNode extends BranchNode
/**
- * Clone the Node
- */
- @Override public ExprNode clone()
- {
- return super.clone();
- }
-
-
-
- /**
* Creates an empty NotNode
*/
public NotNode()
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/OrNode.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/OrNode.java?rev=946175&r1=946174&r2=946175&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/OrNode.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/OrNode.java Wed May 19 13:17:00 2010
@@ -54,15 +54,6 @@ public class OrNode extends BranchNode
/**
- * Clone the Node
- */
- @Override public ExprNode clone()
- {
- return super.clone();
- }
-
-
- /**
* Creates an empty OrNode
*/
public OrNode()
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/PresenceNode.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/PresenceNode.java?rev=946175&r1=946174&r2=946175&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/PresenceNode.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/PresenceNode.java Wed May 19 13:17:00 2010
@@ -41,14 +41,6 @@ public final class PresenceNode extends
/**
- * Clone the Node
- */
- @Override public ExprNode clone()
- {
- return super.clone();
- }
-
- /**
* @see java.lang.Object#toString()
* @return A string representing the AndNode
*/
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/ScopeNode.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/ScopeNode.java?rev=946175&r1=946174&r2=946175&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/ScopeNode.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/ScopeNode.java Wed May 19 13:17:00 2010
@@ -59,17 +59,6 @@ public class ScopeNode extends AbstractE
}
/**
- * Makes a full clone in new memory space of the current node and children
- *
- * @return the clone
- */
- @Override public ExprNode clone()
- {
- return super.clone();
- }
-
-
- /**
* Always returns true since a scope node has no children.
*
* @see ExprNode#isLeaf()
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/SimpleNode.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/SimpleNode.java?rev=946175&r1=946174&r2=946175&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/SimpleNode.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/filter/SimpleNode.java Wed May 19 13:17:00 2010
@@ -60,7 +60,7 @@ public abstract class SimpleNode<T> exte
/**
- * Clone the Node
+ * Makes a full clone in new memory space of the current node and children
*/
@Override public ExprNode clone()
{
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/message/AbstractAbandonableRequest.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/message/AbstractAbandonableRequest.java?rev=946175&r1=946174&r2=946175&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/message/AbstractAbandonableRequest.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/message/AbstractAbandonableRequest.java Wed May 19 13:17:00 2010
@@ -99,9 +99,12 @@ public class AbstractAbandonableRequest
} );
}
-
+
+ // False positive
+ @SuppressWarnings("PMD.UselessOverridingMethod")
class RequestObservable extends Observable
{
+ @Override
public void setChanged()
{
super.setChanged();
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/comparators/DeepTrimToLowerCachingNormalizingComparator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/comparators/DeepTrimToLowerCachingNormalizingComparator.java?rev=946175&r1=946174&r2=946175&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/comparators/DeepTrimToLowerCachingNormalizingComparator.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/comparators/DeepTrimToLowerCachingNormalizingComparator.java Wed May 19 13:17:00 2010
@@ -20,7 +20,6 @@
package org.apache.directory.shared.ldap.schema.comparators;
-import org.apache.directory.shared.ldap.schema.SchemaManager;
import org.apache.directory.shared.ldap.schema.normalizers.CachingNormalizer;
import org.apache.directory.shared.ldap.schema.normalizers.DeepTrimToLowerNormalizer;
@@ -41,15 +40,4 @@ public class DeepTrimToLowerCachingNorma
super( oid, new CachingNormalizer( new DeepTrimToLowerNormalizer( oid ), 10 ),
new ComparableComparator( oid ) );
}
-
-
-
- /**
- * {@inheritDoc}
- */
- public void setSchemaManager( SchemaManager schemaManager )
- {
- super.setSchemaManager( schemaManager );
- }
-
}
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/normalizers/CachingDeepTrimNormalizer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/normalizers/CachingDeepTrimNormalizer.java?rev=946175&r1=946174&r2=946175&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/normalizers/CachingDeepTrimNormalizer.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/normalizers/CachingDeepTrimNormalizer.java Wed May 19 13:17:00 2010
@@ -20,7 +20,6 @@
package org.apache.directory.shared.ldap.schema.normalizers;
-import org.apache.directory.shared.ldap.schema.registries.Registries;
/**
@@ -43,13 +42,4 @@ public class CachingDeepTrimNormalizer e
{
super( new DeepTrimNormalizer() );
}
-
-
- /**
- * {@inheritDoc}
- */
- public void setRegistries( Registries registries )
- {
- super.setRegistries( registries );
- }
}
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/normalizers/CachingDeepTrimToLowerNormalizer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/normalizers/CachingDeepTrimToLowerNormalizer.java?rev=946175&r1=946174&r2=946175&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/normalizers/CachingDeepTrimToLowerNormalizer.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/normalizers/CachingDeepTrimToLowerNormalizer.java Wed May 19 13:17:00 2010
@@ -20,7 +20,6 @@
package org.apache.directory.shared.ldap.schema.normalizers;
-import org.apache.directory.shared.ldap.schema.registries.Registries;
/**
@@ -43,13 +42,4 @@ public class CachingDeepTrimToLowerNorma
{
super( new DeepTrimToLowerNormalizer() );
}
-
-
- /**
- * {@inheritDoc}
- */
- public void setRegistries( Registries registries )
- {
- super.setRegistries( registries );
- }
}
Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/normalizers/CachingDnNormalizer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/normalizers/CachingDnNormalizer.java?rev=946175&r1=946174&r2=946175&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/normalizers/CachingDnNormalizer.java (original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/normalizers/CachingDnNormalizer.java Wed May 19 13:17:00 2010
@@ -21,7 +21,6 @@ package org.apache.directory.shared.ldap
import org.apache.directory.shared.ldap.schema.SchemaManager;
-import org.apache.directory.shared.ldap.schema.registries.Registries;
/**
@@ -49,15 +48,6 @@ public class CachingDnNormalizer extends
/**
* {@inheritDoc}
*/
- public void setRegistries( Registries registries )
- {
- super.setRegistries( registries );
- }
-
-
- /**
- * {@inheritDoc}
- */
public void setSchemaManager( SchemaManager schemaManager )
{
super.normalizer.setSchemaManager( schemaManager );