You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/05 01:10:47 UTC

[GitHub] [beam] damccorm opened a new issue, #21660: Timestamp value conversion in Cloud Datastore connector is wrong

damccorm opened a new issue, #21660:
URL: https://github.com/apache/beam/issues/21660

   Code in org.apache.beam.sdk.io.gcp.datastore.EntityToRow class:
   ```
   
   com.google.protobuf.Timestamp time = val.getTimestampValue();
   long millis = time.getSeconds() * 1000
   + time.getNanos() / 1000;
   return Instant.ofEpochMilli(millis).toDateTime();
   ```
   
   1 millisecond = 1,000,000 nanoseconds
   
   Imported from Jira [BEAM-14541](https://issues.apache.org/jira/browse/BEAM-14541). Original Jira may contain additional context.
   Reported by: yixiaoshen.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on issue #21660: Timestamp value conversion in Cloud Datastore connector is wrong

Posted by GitBox <gi...@apache.org>.
damccorm commented on issue #21660:
URL: https://github.com/apache/beam/issues/21660#issuecomment-1146718680

   Unable to assign user @yixiaoshen. If able, self-assign, otherwise tag @damccorm so that he can assign you. Because of GitHub's spam prevention system, your activity is required to enable assignment in this repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] yixiaoshen commented on issue #21660: Timestamp value conversion in Cloud Datastore connector is wrong

Posted by GitBox <gi...@apache.org>.
yixiaoshen commented on issue #21660:
URL: https://github.com/apache/beam/issues/21660#issuecomment-1147709584

   @damccorm I don't have permission to assign the issue, can you help assign the issue to me? thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on issue #21660: Timestamp value conversion in Cloud Datastore connector is wrong

Posted by GitBox <gi...@apache.org>.
damccorm commented on issue #21660:
URL: https://github.com/apache/beam/issues/21660#issuecomment-1159156067

   > This is fixed by https://github.com/apache/beam/pull/17789, but I don't seem to have permission to .close-issue
   
   You just did 😃 anyone can do it by commenting `.close-issue` like you just did


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] yixiaoshen commented on issue #21660: Timestamp value conversion in Cloud Datastore connector is wrong

Posted by GitBox <gi...@apache.org>.
yixiaoshen commented on issue #21660:
URL: https://github.com/apache/beam/issues/21660#issuecomment-1159152247

   This is fixed by #17789, but I don't seem to have permission to .close-issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on issue #21660: Timestamp value conversion in Cloud Datastore connector is wrong

Posted by GitBox <gi...@apache.org>.
damccorm commented on issue #21660:
URL: https://github.com/apache/beam/issues/21660#issuecomment-1147716847

   Done - FWIW once https://github.com/apache/beam/pull/21719 is merged, you'll be able to self-assign by commenting `.take-issue`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] closed issue #21660: Timestamp value conversion in Cloud Datastore connector is wrong

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #21660: Timestamp value conversion in Cloud Datastore connector is wrong
URL: https://github.com/apache/beam/issues/21660


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org