[GitHub] [incubator-druid] mcbrewster commented on a change in pull request #7758: Web-console: add hostname to tasks view

[GitBox <gi...@apache.org>]

mcbrewster commented on a change in pull request #7758: Web-console: add hostname to tasks view 
URL: https://github.com/apache/incubator-druid/pull/7758#discussion_r287528885
 
 

 ##########
 File path: web-console/src/utils/general.tsx
 ##########
 @@ -88,9 +88,10 @@ function getNeedleAndMode(input: string): NeedleAndMode {
 }
 
 export function booleanCustomTableFilter(filter: Filter, value: any): boolean {
-  if (value === undefined) {
+  if (value === undefined ) {
 
 Review comment:
   because only running tasks have locations so value was null and would error, so I am just automatically excluding anything with out a location.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org