You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@impala.apache.org by "bharath v (JIRA)" <ji...@apache.org> on 2017/06/01 22:19:04 UTC
[jira] [Resolved] (IMPALA-5411) Excessive logging while queries are
loading metadata from ImpalaServer::GetRuntimeProfileStr
[ https://issues.apache.org/jira/browse/IMPALA-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
bharath v resolved IMPALA-5411.
-------------------------------
Resolution: Fixed
Fix Version/s: Impala 2.9.0
http://gerrit.cloudera.org:8080/7042
Change subject: IMPALA-5411: Avoid log spew from GetRuntimeProfileStr
......................................................................
IMPALA-5411: Avoid log spew from GetRuntimeProfileStr
GetRuntimeProfileStr can potentially log lots of spam to the
coordinator logs if there are clients continuously polling the
web endpoints when the table metadata is still loading. The fix
is to use an appopriate Status constructor that doesn't log it.
Change-Id: I2d0ae8c161346b4ec8c865bc23c5c1cd49c1ce7b
---
M be/src/service/impala-server.cc
1 file changed, 1 insertion(+), 1 deletion(-)
> Excessive logging while queries are loading metadata from ImpalaServer::GetRuntimeProfileStr
> --------------------------------------------------------------------------------------------
>
> Key: IMPALA-5411
> URL: https://issues.apache.org/jira/browse/IMPALA-5411
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 2.9.0
> Reporter: Mostafa Mokhtar
> Assignee: bharath v
> Labels: bugbash-2017-05-31
> Fix For: Impala 2.9.0
>
>
> Excessive logging to impalad.INFO while queries are loading metadata from ImpalaServer::GetRuntimeProfileStr
> {code}
> Status ImpalaServer::GetRuntimeProfileStr(const TUniqueId& query_id,
> bool base64_encoded, stringstream* output) {
> DCHECK(output != nullptr);
> // Search for the query id in the active query map
> {
> shared_ptr<ClientRequestState> request_state = GetClientRequestState(query_id);
> if (request_state.get() != nullptr) {
> // For queries in CREATED state, the profile information isn't populated yet.
> if (request_state->query_state() == beeswax::QueryState::CREATED) {
> return Status("Query plan is not ready.");
> }
> lock_guard<mutex> l(*request_state->lock());
> if (base64_encoded) {
> request_state->profile().SerializeToArchiveString(output);
> } else {
> request_state->profile().PrettyPrint(output);
> }
> return Status::OK();
> }
> }
> {code}
> {code}
> I0531 14:11:29.161602 107591 Frontend.java:929] Compiled query.
> I0531 14:11:29.871356 190031 status.cc:122] Query plan is not ready.
> @ 0x83c119 impala::Status::Status()
> @ 0xab871c impala::ImpalaServer::GetRuntimeProfileStr()
> @ 0xae781c impala::ImpalaHttpHandler::QueryProfileEncodedHandler()
> @ 0xbf445a impala::Webserver::RenderUrlWithTemplate()
> @ 0xbf59a7 impala::Webserver::BeginRequestCallback()
> @ 0xc08bb0 (unknown)
> @ 0xc0b32d (unknown)
> @ 0xc0b9bd (unknown)
> @ 0x37dd207aa1 (unknown)
> @ 0x37dcee893d (unknown)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)