[GitHub] graceguo-supercat closed pull request #5159: Fix: Should pass slice_can_edit flag down

[GitBox <gi...@apache.org>]

graceguo-supercat closed pull request #5159: Fix: Should pass slice_can_edit flag down
URL: https://github.com/apache/incubator-superset/pull/5159
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/src/dashboard/components/SliceHeader.jsx b/superset/assets/src/dashboard/components/SliceHeader.jsx
index 50a2a5dfd8..d812181039 100644
--- a/superset/assets/src/dashboard/components/SliceHeader.jsx
+++ b/superset/assets/src/dashboard/components/SliceHeader.jsx
@@ -22,6 +22,7 @@ const propTypes = {
   annotationError: PropTypes.object,
   sliceName: PropTypes.string,
   supersetCanExplore: PropTypes.bool,
+  sliceCanEdit: PropTypes.bool,
 };
 
 const defaultProps = {
@@ -40,6 +41,7 @@ const defaultProps = {
   isExpanded: false,
   sliceName: '',
   supersetCanExplore: false,
+  sliceCanEdit: false,
 };
 
 class SliceHeader extends React.PureComponent {
@@ -56,6 +58,7 @@ class SliceHeader extends React.PureComponent {
       innerRef,
       sliceName,
       supersetCanExplore,
+      sliceCanEdit,
     } = this.props;
 
     const annoationsLoading = t('Annotation layers are still loading.');
@@ -104,6 +107,7 @@ class SliceHeader extends React.PureComponent {
               exploreChart={exploreChart}
               exportCSV={exportCSV}
               supersetCanExplore={supersetCanExplore}
+              sliceCanEdit={sliceCanEdit}
             />
           )}
         </div>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org