[GitHub] [iceberg] nastra commented on a diff in pull request #6799: Core: Use avro compression properties from table properties when writing manifests and manifest lists

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #6799:
URL: https://github.com/apache/iceberg/pull/6799#discussion_r1302679619


##########
core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java:
##########
@@ -170,7 +170,9 @@ private ManifestFile copyManifest(ManifestFile manifest) {
         specsById,
         newFile,
         snapshotId(),
-        summaryBuilder);
+        summaryBuilder,
+        current.properties().get(TableProperties.AVRO_COMPRESSION),

Review Comment:
   what I like about https://github.com/apache/iceberg/pull/8284 is that it just passes a Map of properties rather than the codec + compression level. Maybe we should do the same here to be more future-proof in case we'd want to pass anything else later on?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org