You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/10/10 16:11:28 UTC

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6477: NIFI-10288 Better describe forward slash requirements for Prefix prop…

exceptionfactory commented on code in PR #6477:
URL: https://github.com/apache/nifi/pull/6477#discussion_r991451299


##########
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java:
##########
@@ -181,7 +181,7 @@ public class ListS3 extends AbstractS3Processor implements VerifiableProcessor {
             .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
             .required(false)
             .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
-            .description("The prefix used to filter the object list. In most cases, it should end with a forward slash ('/').")
+            .description("The prefix used to filter the object list. Do not begin with a forward slash ('/').")

Review Comment:
   Instead of rewording the description, it seems better to add the additional sentence, and the parentheses can be removed.
   ```suggestion
               .description("The prefix used to filter the object list. Do not begin with a forward slash '/'. In most cases, it should end with a forward slash '/'.")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org