You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ramitkataria (via GitHub)" <gi...@apache.org> on 2025/07/04 01:24:13 UTC
[PR] More robust handling of `BaseHook.get_connection`'s `CONNECTION_NOT_FOUND` Task SDK exception [airflow]
ramitkataria opened a new pull request, #52838:
URL: https://github.com/apache/airflow/pull/52838
After #51873, the base hook's `get_connection` exception for when connection is not found was changed and was no longer being caught by `AwsGenericHook`. This change fixes that by using a robust approach.
At some point, we should probably make the connection getter raise exceptions in a more consistent manner, maybe once we fully switch over to Task SDK.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More robust handling of `BaseHook.get_connection`'s `CONNECTION_NOT_FOUND` Task SDK exception [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #52838:
URL: https://github.com/apache/airflow/pull/52838#discussion_r2185455790
##########
providers/amazon/src/airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -623,19 +623,16 @@ def conn_config(self) -> AwsConnectionWrapper:
"""Get the Airflow Connection object and wrap it in helper (cached)."""
connection = None
if self.aws_conn_id:
- possible_exceptions: tuple[type[Exception], ...]
-
- if AIRFLOW_V_3_0_PLUS:
- possible_exceptions = (AirflowNotFoundException, AirflowRuntimeError)
- else:
- possible_exceptions = (AirflowNotFoundException,)
-
try:
connection = self.get_connection(self.aws_conn_id)
- except possible_exceptions as e:
- if isinstance(
- e, AirflowNotFoundException
- ) or f"Connection with ID {self.aws_conn_id} not found" in str(e):
+ except Exception as e:
+ not_found_exc_via_core = isinstance(e, AirflowNotFoundException)
+ not_found_exc_via_task_sdk = (
+ AIRFLOW_V_3_0_PLUS
+ and isinstance(e, AirflowRuntimeError)
+ and e.error.error == ErrorType.CONNECTION_NOT_FOUND
+ )
+ if not_found_exc_via_core or not_found_exc_via_task_sdk:
Review Comment:
Created an issue to track too: https://github.com/apache/airflow/issues/52880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More robust handling of `BaseHook.get_connection`'s `CONNECTION_NOT_FOUND` Task SDK exception [airflow]
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #52838:
URL: https://github.com/apache/airflow/pull/52838#discussion_r2185781060
##########
providers/amazon/src/airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -623,19 +623,16 @@ def conn_config(self) -> AwsConnectionWrapper:
"""Get the Airflow Connection object and wrap it in helper (cached)."""
connection = None
if self.aws_conn_id:
- possible_exceptions: tuple[type[Exception], ...]
-
- if AIRFLOW_V_3_0_PLUS:
- possible_exceptions = (AirflowNotFoundException, AirflowRuntimeError)
- else:
- possible_exceptions = (AirflowNotFoundException,)
-
try:
connection = self.get_connection(self.aws_conn_id)
- except possible_exceptions as e:
- if isinstance(
- e, AirflowNotFoundException
- ) or f"Connection with ID {self.aws_conn_id} not found" in str(e):
+ except Exception as e:
+ not_found_exc_via_core = isinstance(e, AirflowNotFoundException)
+ not_found_exc_via_task_sdk = (
+ AIRFLOW_V_3_0_PLUS
+ and isinstance(e, AirflowRuntimeError)
+ and e.error.error == ErrorType.CONNECTION_NOT_FOUND
+ )
+ if not_found_exc_via_core or not_found_exc_via_task_sdk:
Review Comment:
I was thinking we shouldn't make a change to core to accommodate how we were handling it in the provider, but if you think this is an indicator that maybe core can be cleaned up, I can see that and I certainly won't argue with you. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More robust handling of `BaseHook.get_connection`'s `CONNECTION_NOT_FOUND` Task SDK exception [airflow]
Posted by "ramitkataria (via GitHub)" <gi...@apache.org>.
ramitkataria commented on PR #52838:
URL: https://github.com/apache/airflow/pull/52838#issuecomment-3034139735
cc @ferruzzi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More robust handling of `BaseHook.get_connection`'s `CONNECTION_NOT_FOUND` Task SDK exception [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #52838:
URL: https://github.com/apache/airflow/pull/52838#discussion_r2185431023
##########
providers/amazon/src/airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -623,19 +623,16 @@ def conn_config(self) -> AwsConnectionWrapper:
"""Get the Airflow Connection object and wrap it in helper (cached)."""
connection = None
if self.aws_conn_id:
- possible_exceptions: tuple[type[Exception], ...]
-
- if AIRFLOW_V_3_0_PLUS:
- possible_exceptions = (AirflowNotFoundException, AirflowRuntimeError)
- else:
- possible_exceptions = (AirflowNotFoundException,)
-
try:
connection = self.get_connection(self.aws_conn_id)
- except possible_exceptions as e:
- if isinstance(
- e, AirflowNotFoundException
- ) or f"Connection with ID {self.aws_conn_id} not found" in str(e):
+ except Exception as e:
+ not_found_exc_via_core = isinstance(e, AirflowNotFoundException)
+ not_found_exc_via_task_sdk = (
+ AIRFLOW_V_3_0_PLUS
+ and isinstance(e, AirflowRuntimeError)
+ and e.error.error == ErrorType.CONNECTION_NOT_FOUND
+ )
+ if not_found_exc_via_core or not_found_exc_via_task_sdk:
Review Comment:
The fact that we have to handle things separately means we haven't written it well enough in the task sdk! Let me take a stab at it.
I will be handling it better so that both the cases are handled via: `AirflowNotFoundException` and covered by it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More robust handling of `BaseHook.get_connection`'s `CONNECTION_NOT_FOUND` Task SDK exception [airflow]
Posted by "ramitkataria (via GitHub)" <gi...@apache.org>.
ramitkataria commented on code in PR #52838:
URL: https://github.com/apache/airflow/pull/52838#discussion_r2185928014
##########
providers/amazon/src/airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -623,19 +623,16 @@ def conn_config(self) -> AwsConnectionWrapper:
"""Get the Airflow Connection object and wrap it in helper (cached)."""
connection = None
if self.aws_conn_id:
- possible_exceptions: tuple[type[Exception], ...]
-
- if AIRFLOW_V_3_0_PLUS:
- possible_exceptions = (AirflowNotFoundException, AirflowRuntimeError)
- else:
- possible_exceptions = (AirflowNotFoundException,)
-
try:
connection = self.get_connection(self.aws_conn_id)
- except possible_exceptions as e:
- if isinstance(
- e, AirflowNotFoundException
- ) or f"Connection with ID {self.aws_conn_id} not found" in str(e):
+ except Exception as e:
+ not_found_exc_via_core = isinstance(e, AirflowNotFoundException)
+ not_found_exc_via_task_sdk = (
+ AIRFLOW_V_3_0_PLUS
+ and isinstance(e, AirflowRuntimeError)
+ and e.error.error == ErrorType.CONNECTION_NOT_FOUND
+ )
+ if not_found_exc_via_core or not_found_exc_via_task_sdk:
Review Comment:
Sounds good, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] More robust handling of `BaseHook.get_connection`'s `CONNECTION_NOT_FOUND` Task SDK exception [airflow]
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi merged PR #52838:
URL: https://github.com/apache/airflow/pull/52838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org