[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #12487: feat(line): hide splitLine

[GitBox <gi...@apache.org>]

susiwen8 commented on a change in pull request #12487:
URL: https://github.com/apache/incubator-echarts/pull/12487#discussion_r414376631



##########
File path: src/component/axis/CartesianAxisView.js
##########
@@ -137,7 +142,7 @@ var CartesianAxisView = AxisView.extend({
                     y2: p2[1]
                 },
                 style: zrUtil.defaults({
-                    stroke: lineColors[colorIndex]
+                    stroke: (viewLabels && viewLabels[i] && !viewLabels[i].formattedLabel ? 'transparent' : lineColors[colorIndex])

Review comment:
       For better performance, I think we should not draw transparent line, if condition were matched, just don't execute this iteration. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org