You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2016/07/16 01:22:34 UTC
[GitHub] spark pull request #14228: [SPARK-16583] [SQL] [WIP] Improve Partition Pruni...
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/14228
[SPARK-16583] [SQL] [WIP] Improve Partition Pruning in InMemoryTableScanExec
#### What changes were proposed in this pull request?
Currently, column pruning in `InMemoryTableScanExec` only can utilize the predicates whose either left or right side is foldable expressions. We can further extend the existing framework to utilize the predicates in which both sides are attribute references. Through their maximal and minimal boundary values, we can prune the unnecessary partitions. The performance improvement depends on the data distribution and predicates.
TODO: more examples here.
#### How was this patch tested?
TODO: added more test cases
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark inMemory
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14228.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14228
----
commit fd4794debb27cf766ce1fedd0b693b6b7f8b7073
Author: gatorsmile <ga...@gmail.com>
Date: 2016-07-11T21:18:25Z
play1
commit 6cb4291758e27f2bd1c1dc1b4e2fe2ad528d1d1d
Author: gatorsmile <ga...@gmail.com>
Date: 2016-07-12T05:22:20Z
test case fix.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14228: [SPARK-16583] [SQL] [WIP] Improve Partition Pruning in I...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14228
**[Test build #62398 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62398/consoleFull)** for PR 14228 at commit [`6cb4291`](https://github.com/apache/spark/commit/6cb4291758e27f2bd1c1dc1b4e2fe2ad528d1d1d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14228: [SPARK-16583] [SQL] [WIP] Improve Partition Pruning in I...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14228
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62398/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14228: [SPARK-16583] [SQL] [WIP] Improve Partition Pruning in I...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14228
**[Test build #62402 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62402/consoleFull)** for PR 14228 at commit [`143f5cd`](https://github.com/apache/spark/commit/143f5cda2fd0e48ae60095e6a236f8eb4a31c6a5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14228: [SPARK-16583] [SQL] [WIP] Improve Partition Pruning in I...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14228
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14228: [SPARK-16583] [SQL] [WIP] Improve Partition Pruning in I...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14228
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14228: [SPARK-16583] [SQL] [WIP] Improve Partition Pruni...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/14228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14228: [SPARK-16583] [SQL] [WIP] Improve Partition Pruning in I...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14228
**[Test build #62402 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62402/consoleFull)** for PR 14228 at commit [`143f5cd`](https://github.com/apache/spark/commit/143f5cda2fd0e48ae60095e6a236f8eb4a31c6a5).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14228: [SPARK-16583] [SQL] [WIP] Improve Partition Pruni...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14228#discussion_r71058312
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala ---
@@ -148,7 +161,7 @@ private[sql] case class InMemoryTableScanExec(
val value = cachedBatch.stats.get(i, a.dataType)
s"${a.name}: $value"
}.mkString(", ")
- logInfo(s"Skipping partition based on stats $statsString")
+ println(s"Skipping partition based on stats $statsString")
--- End diff --
needs to revert it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14228: [SPARK-16583] [SQL] [WIP] Improve Partition Pruning in I...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14228
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62402/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14228: [SPARK-16583] [SQL] [WIP] Improve Partition Pruning in I...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14228
**[Test build #62398 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62398/consoleFull)** for PR 14228 at commit [`6cb4291`](https://github.com/apache/spark/commit/6cb4291758e27f2bd1c1dc1b4e2fe2ad528d1d1d).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org