You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/13 12:30:11 UTC

[GitHub] [pulsar-client-go] omnilight opened a new issue #379: Problem with github.com/DataDog/zstd

omnilight opened a new issue #379:
URL: https://github.com/apache/pulsar-client-go/issues/379


   #### Expected behavior
   
   Can use this library with other ones using datadog/zstd dependency
   
   #### Actual behavior
   
   During compilation I get error like:
   
   case-insensitive import collision: "github.com/datadog/zstd" and "github.com/DataDog/zstd"
   
   #### Steps to reproduce
   
   1. Require `github.com/datadog/zstd` into your project or use some other library requiring it
   2. Try to compile your code
   
   As `pulsar-client-go` uses `github.com/DataDog/zstd` as it's import dependency under https://github.com/apache/pulsar-client-go/blob/master/pulsar/internal/compression/zstd_cgo.go, compilation fails.
   
   #### System configuration
   **pulsar-client-go**: v0.2.0
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] omnilight commented on issue #379: Problem with github.com/DataDog/zstd

Posted by GitBox <gi...@apache.org>.
omnilight commented on issue #379:
URL: https://github.com/apache/pulsar-client-go/issues/379#issuecomment-717194214


   @wolfstudy Yes, I'm willing to help, will make PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] omnilight commented on issue #379: Problem with github.com/DataDog/zstd

Posted by GitBox <gi...@apache.org>.
omnilight commented on issue #379:
URL: https://github.com/apache/pulsar-client-go/issues/379#issuecomment-718082518


   @wolfstudy PR is created


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] merlimat closed issue #379: Problem with github.com/DataDog/zstd

Posted by GitBox <gi...@apache.org>.
merlimat closed issue #379:
URL: https://github.com/apache/pulsar-client-go/issues/379


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] wolfstudy commented on issue #379: Problem with github.com/DataDog/zstd

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on issue #379:
URL: https://github.com/apache/pulsar-client-go/issues/379#issuecomment-714258101


   @omnilight Maybe we can use `github.com/datadog/zstd` uniformly, which is more in line with the naming convention of the go community. Are you interested in sending a pull request to fix this issue?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org