You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/08/04 22:19:57 UTC
[GitHub] [incubator-tvm] tkonolige opened a new issue #6210: Reshape does not check that shape change is valid
tkonolige opened a new issue #6210:
URL: https://github.com/apache/incubator-tvm/issues/6210
This following code snippet causes zero errors. Running this module with the graph runtime also does not error.
```python
from tvm import relay
x = relay.var("x", shape=[2,3])
y = relay.reshape(x, [7])
f = relay.Function([x], y)
mod = relay.build(f, target="llvm")
```
@tqchen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] mbrookhart commented on issue #6210: Reshape does not check that shape change is valid
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on issue #6210:
URL: https://github.com/apache/incubator-tvm/issues/6210#issuecomment-668919286
I see that the Shape relation function indeed fails to check for a valid reshape. I'm kind of surprised that running it doesn't crash. What value does the 7th element of the output have?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tkonolige commented on issue #6210: Reshape does not check that shape change is valid
Posted by GitBox <gi...@apache.org>.
tkonolige commented on issue #6210:
URL: https://github.com/apache/incubator-tvm/issues/6210#issuecomment-668894462
@mbrookhart
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tkonolige commented on issue #6210: Reshape does not check that shape change is valid
Posted by GitBox <gi...@apache.org>.
tkonolige commented on issue #6210:
URL: https://github.com/apache/incubator-tvm/issues/6210#issuecomment-668975322
@mbrookhart I figured out how to add a shape check to reshape. I will submit the PR tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen closed issue #6210: Reshape does not check that shape change is valid
Posted by GitBox <gi...@apache.org>.
tqchen closed issue #6210:
URL: https://github.com/apache/incubator-tvm/issues/6210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] mbrookhart commented on issue #6210: Reshape does not check that shape change is valid
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on issue #6210:
URL: https://github.com/apache/incubator-tvm/issues/6210#issuecomment-668920518
Doesn't look like the recent dynamic work removed a check, I'll spend some time tomorrow to see if we can add one to the shape relation function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org