You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/03/05 23:26:06 UTC

[GitHub] [incubator-druid] leventov commented on a change in pull request #7120: Locale problem is fixed which fails tests.

leventov commented on a change in pull request #7120: Locale problem is fixed which fails tests.
URL: https://github.com/apache/incubator-druid/pull/7120#discussion_r262733876
 
 

 ##########
 File path: codestyle/druid-forbidden-apis.txt
 ##########
 @@ -35,6 +35,11 @@ java.lang.Math#random() @ Use ThreadLocalRandom.current()
 java.util.regex.Pattern#matches(java.lang.String,java.lang.CharSequence) @ Use String.startsWith(), endsWith(), contains(), or compile and cache a Pattern explicitly
 org.apache.commons.io.FileUtils#getTempDirectory() @ Use org.junit.rules.TemporaryFolder for tests instead
 
+@defaultMessage Uses default locale
 
 Review comment:
   "Use Locale.ENGLISH" would be more constructive

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org