You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/02/13 14:18:13 UTC
svn commit: r1730203 - in /jmeter/trunk/src/core/org/apache/jmeter:
gui/GuiPackage.java gui/action/Start.java gui/util/IconToolbarBean.java
report/processor/CsvFileSampleSource.java
testbeans/gui/GenericTestBeanCustomizer.java threads/TestCompiler.java
Author: pmouawad
Date: Sat Feb 13 13:18:12 2016
New Revision: 1730203
URL: http://svn.apache.org/viewvc?rev=1730203&view=rev
Log:
Fixed some JavaDoc errors and better naming
Patch by Graham Russell Part 3
https://github.com/apache/jmeter/pull/118
Modified:
jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java
jmeter/trunk/src/core/org/apache/jmeter/gui/action/Start.java
jmeter/trunk/src/core/org/apache/jmeter/gui/util/IconToolbarBean.java
jmeter/trunk/src/core/org/apache/jmeter/report/processor/CsvFileSampleSource.java
jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/GenericTestBeanCustomizer.java
jmeter/trunk/src/core/org/apache/jmeter/threads/TestCompiler.java
Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java?rev=1730203&r1=1730202&r2=1730203&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java Sat Feb 13 13:18:12 2016
@@ -377,8 +377,6 @@ public final class GuiPackage implements
* @throws IllegalAccessException
* if access rights do not allow the default constructor to be
* called
- * @throws ClassNotFoundException
- * if the specified GUI class cannot be found
*/
private JMeterGUIComponent getGuiFromCache(Class<?> guiClass, Class<?> testClass) throws InstantiationException,
IllegalAccessException {
Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/action/Start.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/action/Start.java?rev=1730203&r1=1730202&r2=1730203&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/gui/action/Start.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/gui/action/Start.java Sat Feb 13 13:18:12 2016
@@ -92,7 +92,7 @@ public class Start extends AbstractActio
/**
* Start JMeter engine
- * @param noTimer ignore timers
+ * @param ignoreTimer flag to ignore timers
*/
private void startEngine(boolean ignoreTimer) {
GuiPackage gui = GuiPackage.getInstance();
Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/util/IconToolbarBean.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/util/IconToolbarBean.java?rev=1730203&r1=1730202&r2=1730203&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/gui/util/IconToolbarBean.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/gui/util/IconToolbarBean.java Sat Feb 13 13:18:12 2016
@@ -40,7 +40,7 @@ public final class IconToolbarBean {
/**
* Constructor to transform a line value (from icon set file) to a icon bean for toolbar.
* @param strToSplit - the line value (i18n key, ActionNames ID, icon path, optional icon pressed path)
- * @throws JMeterException if error in parsing.
+ * @throws IllegalArgumentException if error in parsing.
*/
IconToolbarBean(final String strToSplit, final String iconSize) throws IllegalArgumentException {
if (strToSplit == null) {
Modified: jmeter/trunk/src/core/org/apache/jmeter/report/processor/CsvFileSampleSource.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/processor/CsvFileSampleSource.java?rev=1730203&r1=1730202&r2=1730203&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/processor/CsvFileSampleSource.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/processor/CsvFileSampleSource.java Sat Feb 13 13:18:12 2016
@@ -158,7 +158,7 @@ public class CsvFileSampleSource extends
* Get a readable time as hours, minutes and seconds from the specified time
* in milliseconds
*
- * @returns A readable string that displays the time provided as
+ * @return A readable string that displays the time provided as
* milliseconds
*/
private final String time(long t) {
Modified: jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/GenericTestBeanCustomizer.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/GenericTestBeanCustomizer.java?rev=1730203&r1=1730202&r2=1730203&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/GenericTestBeanCustomizer.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/GenericTestBeanCustomizer.java Sat Feb 13 13:18:12 2016
@@ -645,8 +645,8 @@ public class GenericTestBeanCustomizer e
* @param descriptor
* @return the group String.
*/
- private static String group(PropertyDescriptor d) {
- String group = (String) d.getValue(GROUP);
+ private static String group(PropertyDescriptor descriptor) {
+ String group = (String) descriptor.getValue(GROUP);
if (group == null){
group = DEFAULT_GROUP;
}
Modified: jmeter/trunk/src/core/org/apache/jmeter/threads/TestCompiler.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/threads/TestCompiler.java?rev=1730203&r1=1730202&r2=1730203&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/threads/TestCompiler.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/threads/TestCompiler.java Sat Feb 13 13:18:12 2016
@@ -274,7 +274,7 @@ public class TestCompiler implements Has
/**
* @param controllers
- * @param i
+ * @param maybeController
*/
private void addDirectParentControllers(List<Controller> controllers, TestElement maybeController) {
if (maybeController instanceof Controller) {