You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Zsolt Miskolczi (Jira)" <ji...@apache.org> on 2023/04/28 14:38:00 UTC

[jira] [Comment Edited] (HIVE-27306) Port Iceberg catalog and handler changes after upgrading Iceberg to 1.2.1

    [ https://issues.apache.org/jira/browse/HIVE-27306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717700#comment-17717700 ] 

Zsolt Miskolczi edited comment on HIVE-27306 at 4/28/23 2:37 PM:
-----------------------------------------------------------------

*Preparation commits:*
{noformat}
b215c4861a0c967f8d2a2b0444697d7877d33992 Hive: Set the Table owner on table creation (#5763)
https://github.com/apache/iceberg/pull/2403/files - before 81bf8d30766b1b129b87abde15239645cb127046
{noformat}
 

*commits between 1.1.0 and 1.2.0:*

+Catalog:+
{noformat}
zsoltmiskolczi@zsmiskolczi-MBP16 iceberg % git log apache-iceberg-1.1.0...apache-iceberg-1.2.1 --pretty=tformat:"%H %s %cs" --reverse -- hive-metastore
6b8f7e0e31a81029b478e7757aba749f5ed27f42 Hive: Set the database owner on namespace creation (#6045) 2022-11-28
6725dc4d5168f41180d4e4acb73fde5b78abf062 Hive: Merge identical catch branch (#6477) 2022-12-22
fede493d59f17ff2bfc0744b296d90bd36130386 Hive: Lock hardening (#6451) 2023-01-11
df87b2e214c7576184e85e1be145069fc0c4d871 Hive: Make UGI current user the owner of new Hive objects (#6324) 2023-01-18
881be5e5d3746da0d8f1a837d2d1bb0f83776b81 Build: Fix minor error-prone warnings (#6629) 2023-01-23
81bf8d30766b1b129b87abde15239645cb127046 Core: Avoid creating new metadata file on registerTable (#6591) 2023-01-25
333227fbd13821365cec1bdbfcb9314a239bea0f Hive: Refactor commit lock mechanism from HiveTableOperations (#6648) 2023-02-03
ba4818b871d36eb34fcdd20dc7f824447f5daa4a Use UGI shortUserName as the default owner of Hive objects (#6955) 2023-03-07

{noformat}
+Handler:+
{noformat}
zsoltmiskolczi@zsmiskolczi-MBP16 iceberg % git log apache-iceberg-1.1.0...apache-iceberg-1.2.1 --pretty=tformat:"%H %s %cs" --reverse -- mr
b5102a6f6603b4ec776c849b2c0e5f212366f11d Build: Bump jackson-annotations from 2.14.0 to 2.14.1 (#6280) 2022-11-28
fede493d59f17ff2bfc0744b296d90bd36130386 Hive: Lock hardening (#6451) 2023-01-11. (It is a duplicate as that change is already in the catalog list)
ab6ba6801cddd70d261357b514103fd8e95775f9 Build: Bump jackson-annotations from 2.14.1 to 2.14.2 (#6687) 2023-02-16

{noformat}
*Extra* that we have to take care of:
{noformat}
c3232b664745ebf761b6a74f4c5b55cc48bfd209: Hive: Use EnvironmentContext instead of Hive Locks to provide transactional commits after HIVE-26882;
{noformat}


was (Author: JIRAUSER290460):
Preparation commits: 

{noformat}
b215c4861a0c967f8d2a2b0444697d7877d33992 Hive: Set the Table owner on table creation (#5763)
https://github.com/apache/iceberg/pull/2403/files - before 81bf8d30766b1b129b87abde15239645cb127046
{noformat}

commits between 1.1.0 and 1.2.0: 

Catalog:

{noformat}
zsoltmiskolczi@zsmiskolczi-MBP16 iceberg % git log apache-iceberg-1.1.0...apache-iceberg-1.2.1 --pretty=tformat:"%H %s %cs" --reverse -- hive-metastore
6b8f7e0e31a81029b478e7757aba749f5ed27f42 Hive: Set the database owner on namespace creation (#6045) 2022-11-28
6725dc4d5168f41180d4e4acb73fde5b78abf062 Hive: Merge identical catch branch (#6477) 2022-12-22
fede493d59f17ff2bfc0744b296d90bd36130386 Hive: Lock hardening (#6451) 2023-01-11
df87b2e214c7576184e85e1be145069fc0c4d871 Hive: Make UGI current user the owner of new Hive objects (#6324) 2023-01-18
881be5e5d3746da0d8f1a837d2d1bb0f83776b81 Build: Fix minor error-prone warnings (#6629) 2023-01-23
81bf8d30766b1b129b87abde15239645cb127046 Core: Avoid creating new metadata file on registerTable (#6591) 2023-01-25
333227fbd13821365cec1bdbfcb9314a239bea0f Hive: Refactor commit lock mechanism from HiveTableOperations (#6648) 2023-02-03
ba4818b871d36eb34fcdd20dc7f824447f5daa4a Use UGI shortUserName as the default owner of Hive objects (#6955) 2023-03-07

{noformat}

Handler:

{noformat}
zsoltmiskolczi@zsmiskolczi-MBP16 iceberg % git log apache-iceberg-1.1.0...apache-iceberg-1.2.1 --pretty=tformat:"%H %s %cs" --reverse -- mr
b5102a6f6603b4ec776c849b2c0e5f212366f11d Build: Bump jackson-annotations from 2.14.0 to 2.14.1 (#6280) 2022-11-28
fede493d59f17ff2bfc0744b296d90bd36130386 Hive: Lock hardening (#6451) 2023-01-11. (It is a duplicate as that change is already in the catalog list)
ab6ba6801cddd70d261357b514103fd8e95775f9 Build: Bump jackson-annotations from 2.14.1 to 2.14.2 (#6687) 2023-02-16

{noformat}

Extra that we have to take care of: 


{noformat}
c3232b664745ebf761b6a74f4c5b55cc48bfd209: Hive: Use EnvironmentContext instead of Hive Locks to provide transactional commits after HIVE-26882;
{noformat}



> Port Iceberg catalog and handler changes after upgrading Iceberg to 1.2.1
> -------------------------------------------------------------------------
>
>                 Key: HIVE-27306
>                 URL: https://issues.apache.org/jira/browse/HIVE-27306
>             Project: Hive
>          Issue Type: Improvement
>          Components: Iceberg integration
>            Reporter: Zsolt Miskolczi
>            Assignee: Zsolt Miskolczi
>            Priority: Major
>
> Iceberg is updated to 1.2.1. 
> Hive Iceberg integration is updated Iceberg version to 1.2.1 and now, we have to refresh catalog and handler updates as well. 
> Key steps: 
> - Identify and port commits that are prerequisites to port changes between 1.1.0 and 1.2.1
> - port catalog and handler changes between 1.1.0 and 1.2.1
> - as an extra, add the recent changes about locking.
> For more details, see the comments at https://github.com/apache/hive/pull/4252



--
This message was sent by Atlassian Jira
(v8.20.10#820010)