[jira] [Commented] (TEXT-175) WordUtils.capitalizeFully(String) only splits by spaces, instead of any whitespace

["Sean Fabri (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEXT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831883#comment-17831883 ] 

Sean Fabri commented on TEXT-175:
---------------------------------

I have picked up the baton with this one - see a new PR in the links. Note that the regression also affected the {{{{{}uncapitalize{}}}()}} methods.

> WordUtils.capitalizeFully(String) only splits by spaces, instead of any whitespace
> ----------------------------------------------------------------------------------
>
>                 Key: TEXT-175
>                 URL: https://issues.apache.org/jira/browse/TEXT-175
>             Project: Commons Text
>          Issue Type: Bug
>    Affects Versions: 1.2, 1.8
>            Reporter: David Lavati
>            Priority: Minor
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> {color:#172b4d}Due to the performance improvements in TEXT-98, this no longer works as originally designed:{color}
>  * {color:#172b4d}{{org.apache.commons.text.WordUtils.capitalizeFully("a\tb\nc")}}{color}
>  ** should return "A\t\B\nC", but returns "A\t\b\nc" instead
>  * {color:#172b4d}{{org.apache.commons.text.WordUtils.capitalizeFully("a b c")}}{color}
>  ** still works as "A B C"
>  
> A possible option while keeping the improvements would be to create a static collection of whitespace codepoints and
>  * either include that into the set, instead of just the single whitespace, as done at [https://github.com/apache/commons-text/commit/fb6d5935451397c561bd52cf1d483975f83b2c7b#diff-9222b0893e00b43fd6519d95e395f9b3R892]
>  * or if that touches too many things, call {{capitalize(String,char[])}}  inside capitalizeFully with these chars as delimiters by default.
>  
> Tested in 1.8



--
This message was sent by Atlassian Jira
(v8.20.10#820010)