You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/13 12:29:29 UTC

[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #2069: feat: request-id plugin form added

iamayushdas opened a new pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [x] New feature provided
   - [x] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   1. added request-id form 
   2. test case added
   
   Please update this section with detailed description.
   
   **Related issues**
   
   fix/resolve #0001
   
   **Checklist:**
   
   - [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   - [x] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#discussion_r689160398



##########
File path: web/src/components/Plugin/UI/request-id.tsx
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react';
+import type { FormInstance } from 'antd/es/form';
+import { Form, Input, Switch } from 'antd';
+import { useIntl } from 'umi';
+
+type Props = {
+  form: FormInstance;
+};
+
+const FORM_ITEM_LAYOUT = {
+  labelCol: {
+    span: 7,
+  },
+  wrapperCol: {
+    span: 18,
+  },
+};
+
+const RequestId: React.FC<Props> = ({ form }) => {
+  const { formatMessage } = useIntl();
+  return (
+    <Form form={form} {...FORM_ITEM_LAYOUT}>
+      <Form.Item
+        label="header_name"
+        name="header_name"
+        initialValue="X-Request-Id"
+        rules={[
+          {
+            message: `${formatMessage({ id: 'component.global.pleaseEnter' })} header_name`,
+          },
+        ]}
+        tooltip={formatMessage({ id: 'component.pluginForm.request-id.header_name.tooltip' })}
+        validateTrigger={['onChange', 'onBlur', 'onClick']}
+      >
+        <Input />
+      </Form.Item>
+      <Form.Item
+        label="include_in_response"
+        name="include_in_response"
+        tooltip={formatMessage({
+          id: 'component.pluginForm.request-id.include_in_response.tooltip',
+        })}
+        valuePropName="checked"

Review comment:
       https://github.com/apache/apisix-dashboard/blob/8f47e3405d2a7dfbdd8999350b1b29d4c6dc7fed/web/src/pages/Route/components/Step1/MetaView.tsx#L180
   
   you can refer to this form field
   
   and for the init value, you can try `initialValue` props




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#discussion_r688913556



##########
File path: web/src/components/Plugin/UI/request-id.tsx
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react';
+import type { FormInstance } from 'antd/es/form';
+import { Form, Input, Switch } from 'antd';
+import { useIntl } from 'umi';
+
+type Props = {
+  form: FormInstance;
+};
+
+const FORM_ITEM_LAYOUT = {
+  labelCol: {
+    span: 7,
+  },
+  wrapperCol: {
+    span: 18,
+  },
+};
+
+const RequestId: React.FC<Props> = ({ form }) => {
+  const { formatMessage } = useIntl();
+  return (
+    <Form form={form} {...FORM_ITEM_LAYOUT}>
+      <Form.Item
+        label="header_name"
+        name="header_name"
+        initialValue="X-Request-Id"
+        rules={[
+          {
+            message: `${formatMessage({ id: 'component.global.pleaseEnter' })} header_name`,
+          },
+        ]}
+        tooltip={formatMessage({ id: 'component.pluginForm.request-id.header_name.tooltip' })}
+        validateTrigger={['onChange', 'onBlur', 'onClick']}
+      >
+        <Input />
+      </Form.Item>
+      <Form.Item
+        label="include_in_response"
+        name="include_in_response"
+        tooltip={formatMessage({
+          id: 'component.pluginForm.request-id.include_in_response.tooltip',
+        })}
+        valuePropName="checked"

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-927132688


   I Will add this, thanks @bzp2010 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-900947837


   cc @Baoyuantop to review ,thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#discussion_r689151619



##########
File path: web/src/components/Plugin/locales/en-US.ts
##########
@@ -128,4 +128,9 @@ export default {
   'component.pluginForm.limit-count.redis_cluster_name.tooltip':
     'When using redis-cluster policy, this property is the name of Redis cluster service nodes.',
   'component.pluginForm.limit-count.atLeast2Characters.rule': 'Please enter at least 2 characters',
+
+  // request-id
+  'component.pluginForm.request-id.header_name.tooltip': 'Request ID header name',
+  'component.pluginForm.request-id.include_in_response.tooltip':
+    'Option to include the unique request ID in the response header',

Review comment:
       Mam could you send me the exact chinese translation of this, or i should use google translate?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-900947837


   cc @Baoyuantop to review ,thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-898425141


   πŸ‘· Deploy Preview for *apisix-dashboard* processing.
   
   
   πŸ”¨ Explore the source changes: 70d8a6af44def4a0e813b793b262f23b2269a639
   
   πŸ” Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6116659ef3623d00088fd362](https://app.netlify.com/sites/apisix-dashboard/deploys/6116659ef3623d00088fd362?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] github-actions[bot] removed a comment on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-986002491


   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the dev@apisix.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-898436841


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2069](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (59065bd) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0972f1610d1c57cbf59c8069dd2acd94c23cdbd4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0972f16) will **decrease** coverage by `1.70%`.
   > The diff coverage is `75.00%`.
   
   > :exclamation: Current head 59065bd differs from pull request most recent head b752ee6. Consider uploading reports for the commit b752ee6 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2069      +/-   ##
   ==========================================
   - Coverage   69.34%   67.63%   -1.71%     
   ==========================================
     Files         186      127      -59     
     Lines        7088     3306    -3782     
     Branches      802      804       +2     
   ==========================================
   - Hits         4915     2236    -2679     
   + Misses       1886     1070     -816     
   + Partials      287        0     -287     
   ```
   
   | Flag | Coverage Ξ” | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `67.63% <75.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ” | |
   |---|---|---|
   | [web/src/components/Plugin/UI/request-id.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZXF1ZXN0LWlkLnRzeA==) | `50.00% <50.00%> (ΓΈ)` | |
   | [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `84.61% <75.00%> (+1.28%)` | :arrow_up: |
   | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `66.25% <100.00%> (+0.20%)` | :arrow_up: |
   | [web/src/components/Plugin/UI/basic-auth.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9iYXNpYy1hdXRoLnRzeA==) | `100.00% <100.00%> (+33.33%)` | :arrow_up: |
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `70.49% <0.00%> (-3.28%)` | :arrow_down: |
   | [api/internal/core/server/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3N0b3JlLmdv) | | |
   | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | | |
   | [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | | |
   | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | | |
   | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | | |
   | ... and [56 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Ξ” = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fd5afe4...b752ee6](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-898436841


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2069](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e20ddbf) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65c7246623fa992755674a5c214fbacaf9293904?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (65c7246) will **decrease** coverage by `2.70%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2069      +/-   ##
   ==========================================
   - Coverage   68.82%   66.12%   -2.71%     
   ==========================================
     Files         181      122      -59     
     Lines        7005     3232    -3773     
     Branches      787      788       +1     
   ==========================================
   - Hits         4821     2137    -2684     
   + Misses       1900     1095     -805     
   + Partials      284        0     -284     
   ```
   
   | Flag | Coverage Ξ” | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `66.12% <33.33%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ” | |
   |---|---|---|
   | [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `76.92% <0.00%> (-6.42%)` | :arrow_down: |
   | [web/src/components/Plugin/UI/request-id.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZXF1ZXN0LWlkLnRzeA==) | `50.00% <50.00%> (ΓΈ)` | |
   | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | | |
   | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | | |
   | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | |
   | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | | |
   | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | |
   | [api/internal/core/server/server.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3NlcnZlci5nbw==) | | |
   | [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | | |
   | [api/internal/core/server/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3N0b3JlLmdv) | | |
   | ... and [53 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Ξ” = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [65c7246...e20ddbf](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-898425141


   βœ”οΈ Deploy Preview for *apisix-dashboard* ready!
   
   
   πŸ”¨ Explore the source changes: e20ddbfd22d4d830ca8859a80657b082249f693d
   
   πŸ” Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61179ba112513e0008be1fa5](https://app.netlify.com/sites/apisix-dashboard/deploys/61179ba112513e0008be1fa5?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2069--apisix-dashboard.netlify.app/](https://deploy-preview-2069--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-927108811


   Hi, @iamayushdas. I'm glad to see you back to health.
   
   I tested your PR and found some omissions.
   ![image](https://user-images.githubusercontent.com/8078418/134769982-8dd9ac02-ac53-4b72-9ba1-ca6667e3bfca.png)
   According to the document, there should be three parameter settings.
   ![image](https://user-images.githubusercontent.com/8078418/134770020-0b0c7382-6346-440c-92ed-2fb75964e8b4.png)
   
   Can you add this function by yourself? If not, I submit a commit that will help you complete this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-898425141


   πŸ‘· Deploy Preview for *apisix-dashboard* processing.
   
   
   πŸ”¨ Explore the source changes: 277fe96aced555920f783f7383db0b67b484f470
   
   πŸ” Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611be8de364b620007ac5a26](https://app.netlify.com/sites/apisix-dashboard/deploys/611be8de364b620007ac5a26?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#discussion_r689151480



##########
File path: web/src/components/Plugin/locales/en-US.ts
##########
@@ -128,4 +128,9 @@ export default {
   'component.pluginForm.limit-count.redis_cluster_name.tooltip':
     'When using redis-cluster policy, this property is the name of Redis cluster service nodes.',
   'component.pluginForm.limit-count.atLeast2Characters.rule': 'Please enter at least 2 characters',
+
+  // request-id
+  'component.pluginForm.request-id.header_name.tooltip': 'Request ID header name',
+  'component.pluginForm.request-id.include_in_response.tooltip':
+    'Option to include the unique request ID in the response header',

Review comment:
       hi @iamayushdas , also need to add i18n keys in the zh-CN file




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#discussion_r688905914



##########
File path: web/src/components/Plugin/UI/request-id.tsx
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react';
+import type { FormInstance } from 'antd/es/form';
+import { Form, Input, Switch } from 'antd';
+import { useIntl } from 'umi';
+
+type Props = {
+  form: FormInstance;
+};
+
+const FORM_ITEM_LAYOUT = {
+  labelCol: {
+    span: 7,
+  },
+  wrapperCol: {
+    span: 18,
+  },
+};
+
+const RequestId: React.FC<Props> = ({ form }) => {
+  const { formatMessage } = useIntl();
+  return (
+    <Form form={form} {...FORM_ITEM_LAYOUT}>
+      <Form.Item
+        label="header_name"
+        name="header_name"
+        initialValue="X-Request-Id"
+        rules={[
+          {
+            message: `${formatMessage({ id: 'component.global.pleaseEnter' })} header_name`,
+          },
+        ]}
+        tooltip={formatMessage({ id: 'component.pluginForm.request-id.header_name.tooltip' })}
+        validateTrigger={['onChange', 'onBlur', 'onClick']}
+      >
+        <Input />
+      </Form.Item>
+      <Form.Item
+        label="include_in_response"
+        name="include_in_response"
+        tooltip={formatMessage({
+          id: 'component.pluginForm.request-id.include_in_response.tooltip',
+        })}
+        valuePropName="checked"

Review comment:
       ![image](https://user-images.githubusercontent.com/72343596/129441244-1faa554f-879d-4a35-b20e-e0a80a7f2c15.png)
   Default true




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-898425141


   πŸ‘· Deploy Preview for *apisix-dashboard* processing.
   
   
   πŸ”¨ Explore the source changes: e20ddbfd22d4d830ca8859a80657b082249f693d
   
   πŸ” Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61179ba112513e0008be1fa5](https://app.netlify.com/sites/apisix-dashboard/deploys/61179ba112513e0008be1fa5?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-898875345


   Okay cool


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-898436841


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2069](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70d8a6a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65c7246623fa992755674a5c214fbacaf9293904?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (65c7246) will **decrease** coverage by `2.70%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2069      +/-   ##
   ==========================================
   - Coverage   68.82%   66.12%   -2.71%     
   ==========================================
     Files         181      122      -59     
     Lines        7005     3232    -3773     
     Branches      787      788       +1     
   ==========================================
   - Hits         4821     2137    -2684     
   + Misses       1900     1095     -805     
   + Partials      284        0     -284     
   ```
   
   | Flag | Coverage Ξ” | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `66.12% <33.33%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ” | |
   |---|---|---|
   | [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `76.92% <0.00%> (-6.42%)` | :arrow_down: |
   | [web/src/components/Plugin/UI/request-id.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZXF1ZXN0LWlkLnRzeA==) | `50.00% <50.00%> (ΓΈ)` | |
   | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | |
   | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | |
   | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | | |
   | [api/cmd/start.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zdGFydC5nbw==) | | |
   | [api/cmd/stop.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zdG9wLmdv) | | |
   | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | | |
   | [api/cmd/status.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zdGF0dXMuZ28=) | | |
   | [api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==) | | |
   | ... and [53 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2069/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Ξ” = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [65c7246...70d8a6a](https://codecov.io/gh/apache/apisix-dashboard/pull/2069?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-898425141


   βœ”οΈ Deploy Preview for *apisix-dashboard* ready!
   
   
   πŸ”¨ Explore the source changes: 70d8a6af44def4a0e813b793b262f23b2269a639
   
   πŸ” Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6116659ef3623d00088fd362](https://app.netlify.com/sites/apisix-dashboard/deploys/6116659ef3623d00088fd362?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2069--apisix-dashboard.netlify.app/](https://deploy-preview-2069--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-927132688


   Will add this, thanks 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-899129192


   for the test cases:
   
   1. should configure `request-id` plugin with `form` successfully
   assert the default form item values at during this case
   2. should configure `request-id` plugin when switch `form` mode to `json` mode successfully
   
   thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-898425141


   πŸ‘· Deploy Preview for *apisix-dashboard* processing.
   
   
   πŸ”¨ Explore the source changes: 55712f3f3d27f6c1a8599fb38528c740bf9123b0
   
   πŸ” Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611be7fa9e78b500075c0279](https://app.netlify.com/sites/apisix-dashboard/deploys/611be7fa9e78b500075c0279?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-898425141


   βœ”οΈ Deploy Preview for *apisix-dashboard* ready!
   
   
   πŸ”¨ Explore the source changes: 43741b4605e886755a68e3c118de983ce70bfe19
   
   πŸ” Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611be96c513a280007657129](https://app.netlify.com/sites/apisix-dashboard/deploys/611be96c513a280007657129?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2069--apisix-dashboard.netlify.app/](https://deploy-preview-2069--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-898425141


   πŸ‘· Deploy Preview for *apisix-dashboard* processing.
   
   
   πŸ”¨ Explore the source changes: a8cb8bf9731157a9d998baacfeb1d2817eabb546
   
   πŸ” Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611be90ac305de000708fcde](https://app.netlify.com/sites/apisix-dashboard/deploys/611be90ac305de000708fcde?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-926327478


   @liuxiran @juzhiyuan @guoqqqi @bzp2010 @LiteSun  have a look please, sorry for delay as i going through an health issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-898425141


   πŸ‘· Deploy Preview for *apisix-dashboard* processing.
   
   
   πŸ”¨ Explore the source changes: 43741b4605e886755a68e3c118de983ce70bfe19
   
   πŸ” Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611be96c513a280007657129](https://app.netlify.com/sites/apisix-dashboard/deploys/611be96c513a280007657129?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-898425141


   πŸ‘· Deploy Preview for *apisix-dashboard* processing.
   
   
   πŸ”¨ Explore the source changes: 59d1c63a7315cb0e262f67ed2574ffebdede3ad6
   
   πŸ” Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611be5a2f9dbc200082b577a](https://app.netlify.com/sites/apisix-dashboard/deploys/611be5a2f9dbc200082b577a?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#discussion_r689153715



##########
File path: web/src/components/Plugin/locales/en-US.ts
##########
@@ -128,4 +128,9 @@ export default {
   'component.pluginForm.limit-count.redis_cluster_name.tooltip':
     'When using redis-cluster policy, this property is the name of Redis cluster service nodes.',
   'component.pluginForm.limit-count.atLeast2Characters.rule': 'Please enter at least 2 characters',
+
+  // request-id
+  'component.pluginForm.request-id.header_name.tooltip': 'Request ID header name',
+  'component.pluginForm.request-id.include_in_response.tooltip':
+    'Option to include the unique request ID in the response header',

Review comment:
       for header name: ` request ID ηš„θ―·ζ±‚ε€΄εη§°`
   for response : `ε“εΊ”ε€΄δΈ­εŒ…ε« request ID 选鑹`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-898425141






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-927132688


   need your help to do this. @bzp2010 , can you guide me through this
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-898425668


   cc @juzhiyuan @guoqqqi @liuxiran @LiteSun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Baoyuantop commented on a change in pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on a change in pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#discussion_r691731582



##########
File path: web/src/components/Plugin/UI/request-id.tsx
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react';
+import type { FormInstance } from 'antd/es/form';
+import { Form, Input, Switch } from 'antd';
+import { useIntl } from 'umi';
+
+type Props = {
+  form: FormInstance;
+};
+
+const FORM_ITEM_LAYOUT = {
+  labelCol: {
+    span: 7,
+  },
+  wrapperCol: {
+    span: 18,
+  },
+};
+
+const RequestId: React.FC<Props> = ({ form }) => {
+  const { formatMessage } = useIntl();
+  return (
+    <Form form={form} {...FORM_ITEM_LAYOUT}>
+      <Form.Item
+        label="header_name"
+        name="header_name"
+        initialValue="X-Request-Id"
+        rules={[
+          {
+            message: `${formatMessage({ id: 'component.global.pleaseEnter' })} header_name`,
+          },
+        ]}
+        tooltip={formatMessage({ id: 'component.pluginForm.request-id.header_name.tooltip' })}
+        validateTrigger={['onChange', 'onBlur', 'onClick']}
+      >
+        <Input />
+      </Form.Item>
+      <Form.Item
+        label="include_in_response"
+        name="include_in_response"
+        tooltip={formatMessage({
+          id: 'component.pluginForm.request-id.include_in_response.tooltip',
+        })}
+        valuePropName="checked"
+      >
+        <Switch />

Review comment:
       `defaultChecked` = `true` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] github-actions[bot] commented on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-986002491


   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the dev@apisix.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] github-actions[bot] removed a comment on pull request #2069: feat: request-id plugin form added

Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #2069:
URL: https://github.com/apache/apisix-dashboard/pull/2069#issuecomment-986002491


   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the dev@apisix.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org