You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/23 07:57:55 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3151: Fix nxstyle warning
xiaoxiang781216 opened a new pull request #3151:
URL: https://github.com/apache/incubator-nuttx/pull/3151
## Summary
boards/arm/imxrt: Fix nxstyle warning in imxrt1060-evk/src/imxrt_boot.c
arch/arm: Fix nxstyle warning in stm32h7/stm32_dma.c
## Impact
Should no, only style change
## Testing
Pass the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea merged pull request #3151: Fix nxstyle warning
Posted by GitBox <gi...@apache.org>.
jerpelea merged pull request #3151:
URL: https://github.com/apache/incubator-nuttx/pull/3151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3151: Fix nxstyle warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #3151:
URL: https://github.com/apache/incubator-nuttx/pull/3151#issuecomment-804706962
@davids5 the warning left in https://github.com/apache/incubator-nuttx/pull/3143 is fixed here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3151: Fix nxstyle warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3151:
URL: https://github.com/apache/incubator-nuttx/pull/3151#issuecomment-804833052
> @xiaoxiang781216 - Thank you.
>
> Question: It this to the coding standard or just make the tool happy?
I trust tool. Different people may interpret the coding standard in the different way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3151: Fix nxstyle warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3151:
URL: https://github.com/apache/incubator-nuttx/pull/3151#issuecomment-804706962
@davids5 : the warning left in https://github.com/apache/incubator-nuttx/pull/3143 is fixed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3151: Fix nxstyle warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #3151:
URL: https://github.com/apache/incubator-nuttx/pull/3151#issuecomment-804833052
> @xiaoxiang781216 - Thank you.
>
> Question: It this to the coding standard or just make the tool happy?
I trust tool because different people may interpret the coding standard in the different way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3151: Fix nxstyle warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #3151:
URL: https://github.com/apache/incubator-nuttx/pull/3151#issuecomment-804706962
@davids5 the warning left in https://github.com/apache/incubator-nuttx/pull/3143 is fixed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org