[GitHub] [incubator-dolphinscheduler] lenboo commented on a change in pull request #4513: [Improvement][service] Refactor service module to fix code smell

[GitBox <gi...@apache.org>]

lenboo commented on a change in pull request #4513:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4513#discussion_r566736297



##########
File path: dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -508,16 +506,14 @@ public void createRecoveryWaitingThreadCommand(Command originCommand, ProcessIns
     /**
      * get schedule time from command
      *
-     * @param command  command
+     * @param command command
      * @param cmdParam cmdParam map
      * @return date
      */
     private Date getScheduleTime(Command command, Map<String, String> cmdParam) {
         Date scheduleTime = command.getScheduleTime();
-        if (scheduleTime == null) {
-            if (cmdParam != null && cmdParam.containsKey(CMDPARAM_COMPLEMENT_DATA_START_DATE)) {
-                scheduleTime = DateUtils.stringToDate(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE));
-            }
+        if (scheduleTime == null && cmdParam != null && cmdParam.containsKey(CMDPARAM_COMPLEMENT_DATA_START_DATE)) {

Review comment:
       three judgement is complicated.
   the schedulerTime can be judged alone.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org