[GitHub] [iceberg] rdblue commented on a diff in pull request #6698: Core, Hive: Support pluggable ClientPool

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #6698:
URL: https://github.com/apache/iceberg/pull/6698#discussion_r1092396812


##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -119,6 +119,8 @@ private CatalogProperties() {}
       "client.pool.cache.eviction-interval-ms";
   public static final long CLIENT_POOL_CACHE_EVICTION_INTERVAL_MS_DEFAULT =
       TimeUnit.MINUTES.toMillis(5);
+  /** Name of the custom {@link ClientPool} implementation class. */
+  public static final String CLIENT_POOL_IMPL = "client-pool-impl";

Review Comment:
   Is it strictly necessary to inject this using reflection? If this is for customization in a certain environment, then maybe it would be better to allow customization in a different way?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org