You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/05 22:33:33 UTC
[GitHub] [yunikorn-k8shim] craigcondit opened a new pull request, #497: [YUNIKORN-1381] Move admission controller code out of plugins package
craigcondit opened a new pull request, #497:
URL: https://github.com/apache/yunikorn-k8shim/pull/497
### What is this PR for?
Refactor the admission controller into its own package, separate from the plugins package. Also move the entrypoint into pkg/cmd/admissioncontroller/main.go to match other entry points.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [x] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1341
### How should this be tested?
No functional changes, existing e2e tests cover this.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #497: [YUNIKORN-1381] Move admission controller code out of plugins package
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #497: [YUNIKORN-1381] Move admission controller code out of plugins package
URL: https://github.com/apache/yunikorn-k8shim/pull/497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit commented on pull request #497: [YUNIKORN-1381] Move admission controller code out of plugins package
Posted by GitBox <gi...@apache.org>.
craigcondit commented on PR #497:
URL: https://github.com/apache/yunikorn-k8shim/pull/497#issuecomment-1338316245
> The only nit is import ordering in a couple of files (3-4)
Fixed (only one I saw was main.go).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #497: [YUNIKORN-1381] Move admission controller code out of plugins package
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #497:
URL: https://github.com/apache/yunikorn-k8shim/pull/497#issuecomment-1338282800
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/497?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#497](https://codecov.io/gh/apache/yunikorn-k8shim/pull/497?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e84c4e) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/1ff14f1b8960d579e45bbff7e39e13a8c3594c5f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1ff14f1) will **increase** coverage by `0.89%`.
> The diff coverage is `83.33%`.
```diff
@@ Coverage Diff @@
## master #497 +/- ##
==========================================
+ Coverage 66.67% 67.57% +0.89%
==========================================
Files 43 42 -1
Lines 7563 7463 -100
==========================================
Hits 5043 5043
+ Misses 2332 2232 -100
Partials 188 188
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/497?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/admission/conf/am\_conf.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkbWlzc2lvbi9jb25mL2FtX2NvbmYuZ28=) | `61.47% <ø> (ø)` | |
| [pkg/admission/metadata/extract.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkbWlzc2lvbi9tZXRhZGF0YS9leHRyYWN0Lmdv) | `100.00% <ø> (ø)` | |
| [pkg/admission/metadata/labels.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkbWlzc2lvbi9tZXRhZGF0YS9sYWJlbHMuZ28=) | `100.00% <ø> (ø)` | |
| [pkg/admission/metadata/usergroup.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkbWlzc2lvbi9tZXRhZGF0YS91c2VyZ3JvdXAuZ28=) | `78.65% <ø> (ø)` | |
| [pkg/admission/webhook\_manager.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkbWlzc2lvbi93ZWJob29rX21hbmFnZXIuZ28=) | `77.06% <ø> (ø)` | |
| [pkg/admission/admission\_controller.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkbWlzc2lvbi9hZG1pc3Npb25fY29udHJvbGxlci5nbw==) | `61.69% <83.33%> (ø)` | |
| [pkg/cmd/admissioncontroller/main.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NtZC9hZG1pc3Npb25jb250cm9sbGVyL21haW4uZ28=) | | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org