You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2018/05/10 15:47:12 UTC
[GitHub] activemq-artemis pull request #2080: ARTEMIS-1851 avoid exception in isRepli...
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2080
ARTEMIS-1851 avoid exception in isReplicaSync()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1851
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2080.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2080
----
commit 325286ac000fa334928d69455ff13cd4a145da5b
Author: Justin Bertram <jb...@...>
Date: 2018-05-10T15:44:30Z
ARTEMIS-1851 avoid exception in isReplicaSync()
----
---
[GitHub] activemq-artemis pull request #2080: ARTEMIS-1851 avoid exception in isRepli...
Posted by jdanekrh <gi...@git.apache.org>.
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2080#discussion_r187455572
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
@@ -946,7 +946,7 @@ public boolean isReplicaSync() {
} else if (activation instanceof SharedNothingBackupActivation) {
return ((SharedNothingBackupActivation) activation).isRemoteBackupUpToDate();
} else {
- throw ActiveMQMessageBundle.BUNDLE.methodNotApplicable();
--- End diff --
Makes sense, although ARTEMIS-1018 Duplicate error ids on different error mesages. Thanks for not making it worse, I guess.
---
[GitHub] activemq-artemis issue #2080: ARTEMIS-1851 avoid exception in isReplicaSync(...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2080
can you rebase to quick another build please?
---
[GitHub] activemq-artemis pull request #2080: ARTEMIS-1851 avoid exception in isRepli...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2080
---
[GitHub] activemq-artemis pull request #2080: ARTEMIS-1851 avoid exception in isRepli...
Posted by jdanekrh <gi...@git.apache.org>.
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2080#discussion_r187450038
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
@@ -946,7 +946,7 @@ public boolean isReplicaSync() {
} else if (activation instanceof SharedNothingBackupActivation) {
return ((SharedNothingBackupActivation) activation).isRemoteBackupUpToDate();
} else {
- throw ActiveMQMessageBundle.BUNDLE.methodNotApplicable();
--- End diff --
Isn't this the only place where this error message was generated? If so, then it may be also deleted at
https://github.com/apache/activemq-artemis/blob/e5ef7d37ae255b9ed478bc4b45586cf8a179b18b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQMessageBundle.java#L383-L384
---
[GitHub] activemq-artemis pull request #2080: ARTEMIS-1851 avoid exception in isRepli...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2080#discussion_r187453307
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
@@ -946,7 +946,7 @@ public boolean isReplicaSync() {
} else if (activation instanceof SharedNothingBackupActivation) {
return ((SharedNothingBackupActivation) activation).isRemoteBackupUpToDate();
} else {
- throw ActiveMQMessageBundle.BUNDLE.methodNotApplicable();
--- End diff --
@jdanekrh, yes. That is the only place where that message was used but I elected not to delete that method so that developers would know that the message's id (i.e. `119118`) shouldn't be used again since message ids should be unique.
---
[GitHub] activemq-artemis issue #2080: ARTEMIS-1851 avoid exception in isReplicaSync(...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2080
I just tried without today's commits.. and I don't see anything that could cause it... they made changes .. perhaps we need new settings
---