You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by harikrishna-patnala <gi...@git.apache.org> on 2015/09/21 13:08:00 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8888: Xenserver 6.0.2 host stu...
GitHub user harikrishna-patnala opened a pull request:
https://github.com/apache/cloudstack/pull/861
CLOUDSTACK-8888: Xenserver 6.0.2 host stuck in disconnected state aft…
Xenserver 6.0.2 hosts are stuck in disconnected state after CS upgrade to 4.6. This is because xenserver602resource class is not there in 4.6 branch and existing hosts running on v6.0.2 are not handled properly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/harikrishna-patnala/cloudstack CLOUDSTACK-8888
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/861.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #861
----
commit 61c85fe2dca09b0189b7a9dae7a29d8692dcca0c
Author: Harikrishna Patnala <ha...@citrix.com>
Date: 2015-09-21T10:17:15Z
CLOUDSTACK-8888: Xenserver 6.0.2 host stuck in disconnected state after upgrade to 4.6
XenServer602Resource class is removed but existing xenserver 6.0.2 hosts are not handled properly.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8888: Xenserver 6.0.2 host stu...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/861#issuecomment-142173025
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8888: Xenserver 6.0.2 host stu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/861
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8888: Xenserver 6.0.2 host stu...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/861#issuecomment-144500362
@koushik-das Thanks!
Another benefit: this is an easier change that doesn't require much testing (all it does it execute a SQL query at upgrade time).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8888: Xenserver 6.0.2 host stu...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/861#issuecomment-144347634
I have updated #883 with my comments, looking at the changes it shouldn't be required. Lets wait for @SudharmaJain response
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8888: Xenserver 6.0.2 host stu...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/861#issuecomment-145928165
@koushik-das @runseb, no response from @SudharmaJain on this matter. I propose to merge this PR #861 and close the other (#883). Agree?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8888: Xenserver 6.0.2 host stu...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/861#issuecomment-146079758
@remibergsma +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8888: Xenserver 6.0.2 host stu...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/861#issuecomment-146119100
I agree on principles, but I have not tested any of this. would be good if @SudharmaJain could confirm that this PR fixes his problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8888: Xenserver 6.0.2 host stu...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/861#issuecomment-147113023
I commented on #883 and will merge this in a few days. Let's hope @SudharmaJain responds.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8888: Xenserver 6.0.2 host stu...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/861#issuecomment-144320963
@harikrishna-patnala and @koushik-das I agree with @remibergsma please advise on how you want to proceed, considering #883 reimplements the 602 resource.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8888: Xenserver 6.0.2 host stu...
Posted by harikrishna-patnala <gi...@git.apache.org>.
Github user harikrishna-patnala commented on the pull request:
https://github.com/apache/cloudstack/pull/861#issuecomment-142174711
Thanks Koushik, here is the commit which removed the class XenServer602Resource.
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=81c5e184ba998a6ccd75dfffad32cbe5dbc8c2ec
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8888: Xenserver 6.0.2 host stu...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/861#issuecomment-143524258
@harikrishna-patnala Please check PR #883 If this gets in, then I think your problem is also solved?
Maybe someone can check both PR #883 and #861 and decide what's the best way forward. What's your opinion @koushik-das ? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---