You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2017/08/28 16:09:45 UTC
Review Request 61950: GEODE-3519 servers are not locking on remove or
invalidate ops initiated by clients
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61950/
-----------------------------------------------------------
Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
Bugs: geode-3519
https://issues.apache.org/jira/browse/geode-3519
Repository: geode
Description
-------
While investigating dlocktoken cleanup I discovered that a number of operations coming from a client were not locking entries for Scope.GLOBAL regions on servers. Only put, putIfAbsent and variants of replace were obtaining locks.
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java d9ed4edeff629b87d0fce2463fa9b22723b57d9a
geode-core/src/test/java/org/apache/geode/cache30/ClientServerCCEDUnitTest.java b4224e0dcba91ee75cf1abf185f6fc9fbe22390f
Diff: https://reviews.apache.org/r/61950/diff/1/
Testing
-------
precheckin, new integration test
Thanks,
Bruce Schuchardt
Re: Review Request 61950: GEODE-3519 servers are not locking on
remove or invalidate ops initiated by clients
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61950/#review183950
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On Aug. 28, 2017, 4:09 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61950/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2017, 4:09 p.m.)
>
>
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Bugs: geode-3519
> https://issues.apache.org/jira/browse/geode-3519
>
>
> Repository: geode
>
>
> Description
> -------
>
> While investigating dlocktoken cleanup I discovered that a number of operations coming from a client were not locking entries for Scope.GLOBAL regions on servers. Only put, putIfAbsent and variants of replace were obtaining locks.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java d9ed4edeff629b87d0fce2463fa9b22723b57d9a
> geode-core/src/test/java/org/apache/geode/cache30/ClientServerCCEDUnitTest.java b4224e0dcba91ee75cf1abf185f6fc9fbe22390f
>
>
> Diff: https://reviews.apache.org/r/61950/diff/1/
>
>
> Testing
> -------
>
> precheckin, new integration test
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 61950: GEODE-3519 servers are not locking on
remove or invalidate ops initiated by clients
Posted by Alexander Murmann <am...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61950/#review184078
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Murmann
On Aug. 28, 2017, 4:09 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61950/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2017, 4:09 p.m.)
>
>
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Bugs: geode-3519
> https://issues.apache.org/jira/browse/geode-3519
>
>
> Repository: geode
>
>
> Description
> -------
>
> While investigating dlocktoken cleanup I discovered that a number of operations coming from a client were not locking entries for Scope.GLOBAL regions on servers. Only put, putIfAbsent and variants of replace were obtaining locks.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java d9ed4edeff629b87d0fce2463fa9b22723b57d9a
> geode-core/src/test/java/org/apache/geode/cache30/ClientServerCCEDUnitTest.java b4224e0dcba91ee75cf1abf185f6fc9fbe22390f
>
>
> Diff: https://reviews.apache.org/r/61950/diff/1/
>
>
> Testing
> -------
>
> precheckin, new integration test
>
>
> Thanks,
>
> Bruce Schuchardt
>
>