You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/07 10:40:20 UTC

[GitHub] [incubator-nuttx] johannes-nivus opened a new pull request #1531: USB MSC state change notifier and USB MSC automount for Freedom K28

johannes-nivus opened a new pull request #1531:
URL: https://github.com/apache/incubator-nuttx/pull/1531


   ## Summary
   Added USB MSC state change notifier in notifier work queue.
   Added USB MSC automount for Freedom K28 using the above.
   
   ## Impact
   When a state change on USB mass storage class is detected, a notification is sent to the notifier work queue.
   The qualifier tells if it is a connect or disconnect event.
   The corresponding Kconfig option is USBHOST_MSC_NOTIFIER.
   
   ## Testing
   Introduced USB automount for Kinetis Freedom K28 board. Works only for one USB device.
   
   Possible improvement:
   I could imagine providing another field in the notifier struct would allow for sending at least the connection number (or sdchar) with the event, which would allow to determine the exact block device we want to mount.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo merged pull request #1531: USB MSC state change notifier and USB MSC automount for Freedom K28

Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #1531:
URL: https://github.com/apache/incubator-nuttx/pull/1531


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] johannes-nivus edited a comment on pull request #1531: USB MSC state change notifier and USB MSC automount for Freedom K28

Posted by GitBox <gi...@apache.org>.
johannes-nivus edited a comment on pull request #1531:
URL: https://github.com/apache/incubator-nuttx/pull/1531#issuecomment-670845122


   I just corrected some errors in comments (wrong function names).
   Please be aware that the nxstyle violations (mixed cased identifiers) are related to an already present header.
   Again I can offer rework the header and the related source files. Please advise.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #1531: USB MSC state change notifier and USB MSC automount for Freedom K28

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1531:
URL: https://github.com/apache/incubator-nuttx/pull/1531#issuecomment-671058119


   Ok, I think it is in good shape now! Let's wait for @patacongo review.
   
   BTW, should I open an issue to let nxstyle to ignore mixed case when we have "*n_*" like USBPHY_PLL_SICn_PLL_DIV_SEL_MASK (for any REG_NAME_INSTANCEn_BLABLABLA ) ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] johannes-nivus commented on pull request #1531: USB MSC state change notifier and USB MSC automount for Freedom K28

Posted by GitBox <gi...@apache.org>.
johannes-nivus commented on pull request #1531:
URL: https://github.com/apache/incubator-nuttx/pull/1531#issuecomment-670847310


   Converted to draft:
   I have an idea how to signal the sdchar, which I'd like to try before.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] johannes-nivus commented on pull request #1531: USB MSC state change notifier and USB MSC automount for Freedom K28

Posted by GitBox <gi...@apache.org>.
johannes-nivus commented on pull request #1531:
URL: https://github.com/apache/incubator-nuttx/pull/1531#issuecomment-671077955


   I found a bug in usbhost_freedevno which had been there before. I pushed to this branch.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] johannes-nivus commented on pull request #1531: USB MSC state change notifier and USB MSC automount for Freedom K28

Posted by GitBox <gi...@apache.org>.
johannes-nivus commented on pull request #1531:
URL: https://github.com/apache/incubator-nuttx/pull/1531#issuecomment-671055858


   Another comment:
   I did not use the fs_automount for USB on purpose, because I wasn't able to find a clean solution for a dynamic amount of instances.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] johannes-nivus commented on pull request #1531: USB MSC state change notifier and USB MSC automount for Freedom K28

Posted by GitBox <gi...@apache.org>.
johannes-nivus commented on pull request #1531:
URL: https://github.com/apache/incubator-nuttx/pull/1531#issuecomment-670845122


   I just corrected some errors in comments (wrong function names).
   Please be aware that the nxstyle violations (mixed cased identifiers) are again related to an already present header.
   Again I can offer rework the header and the related source files. Pleas advise.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org