[GitHub] [superset] AAfghahi commented on a diff in pull request #20754: fix: set allow `filter_select` for Query objects in Explore

[GitBox <gi...@apache.org>]

AAfghahi commented on code in PR #20754:
URL: https://github.com/apache/superset/pull/20754#discussion_r924855102


##########
superset/models/helpers.py:
##########
@@ -1189,6 +1189,38 @@ def _get_top_groups(
 
         return or_(*groups)
 
+    def values_for_column(self, column_name: str, limit: int = 10000) -> List[Any]:

Review Comment:
   I think that a better idea here is to use the Max display limit. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org