You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eumiro (via GitHub)" <gi...@apache.org> on 2023/08/18 17:29:28 UTC

[GitHub] [airflow] eumiro commented on a diff in pull request #33453: Simplify 'X for X in Y' to 'Y' where applicable

eumiro commented on code in PR #33453:
URL: https://github.com/apache/airflow/pull/33453#discussion_r1298693274


##########
tests/providers/google/cloud/transfers/test_sql_to_gcs.py:
##########
@@ -557,7 +557,7 @@ def test__write_local_data_files_csv_does_not_write_on_empty_rows(self):
         with pytest.raises(StopIteration):
             next(files)["file_handle"]
 
-        assert len([f for f in files]) == 0
+        assert not list(files)

Review Comment:
   This is really elegant!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org