You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2020/06/28 14:57:17 UTC
[GitHub] [jackrabbit-oak] neerajgrg opened a new pull request #235: s3Connector changes for regions apart from aws default regions
neerajgrg opened a new pull request #235:
URL: https://github.com/apache/jackrabbit-oak/pull/235
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] neerajgrg commented on pull request #235: s3Connector changes for regions apart from aws default regions
Posted by GitBox <gi...@apache.org>.
neerajgrg commented on pull request #235:
URL: https://github.com/apache/jackrabbit-oak/pull/235#issuecomment-651049146
@amit-jain All test cases are working fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] neerajgrg commented on pull request #235: s3Connector changes for regions apart from aws default regions
Posted by GitBox <gi...@apache.org>.
neerajgrg commented on pull request #235:
URL: https://github.com/apache/jackrabbit-oak/pull/235#issuecomment-651773988
Thanks @amit-jain I need this patch for AEM 6.5, for that i think we need to merge this path in branch 1.10 as well. Please let me know do i raise a new pull request for that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] amit-jain commented on pull request #235: s3Connector changes for regions apart from aws default regions
Posted by GitBox <gi...@apache.org>.
amit-jain commented on pull request #235:
URL: https://github.com/apache/jackrabbit-oak/pull/235#issuecomment-651071739
Thanks @neerajgrg for confirming, will take over.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] neerajgrg commented on pull request #235: s3Connector changes for regions apart from aws default regions
Posted by GitBox <gi...@apache.org>.
neerajgrg commented on pull request #235:
URL: https://github.com/apache/jackrabbit-oak/pull/235#issuecomment-650989310
@amit-jain Have run the test file TestS3DSWithSSES3 with eu_ireland, us standard and singapore region. All the test cases are working fine in this class. Please let me know if any other test cases needed to run
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] amit-jain commented on pull request #235: s3Connector changes for regions apart from aws default regions
Posted by GitBox <gi...@apache.org>.
amit-jain commented on pull request #235:
URL: https://github.com/apache/jackrabbit-oak/pull/235#issuecomment-650995697
@neerajgrg Yes please run all tests not just this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] amit-jain commented on pull request #235: s3Connector changes for regions apart from aws default regions
Posted by GitBox <gi...@apache.org>.
amit-jain commented on pull request #235:
URL: https://github.com/apache/jackrabbit-oak/pull/235#issuecomment-651559243
Created https://issues.apache.org/jira/browse/OAK-9128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] neerajgrg commented on pull request #235: s3Connector changes for regions apart from aws default regions
Posted by GitBox <gi...@apache.org>.
neerajgrg commented on pull request #235:
URL: https://github.com/apache/jackrabbit-oak/pull/235#issuecomment-651049936
tested with all three regions eu_ireland, us standard and singapore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] amit-jain commented on pull request #235: s3Connector changes for regions apart from aws default regions
Posted by GitBox <gi...@apache.org>.
amit-jain commented on pull request #235:
URL: https://github.com/apache/jackrabbit-oak/pull/235#issuecomment-651074198
@neerajgrg is there a jira issue associated with the PR? Please create one if not available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] amit-jain commented on pull request #235: s3Connector changes for regions apart from aws default regions
Posted by GitBox <gi...@apache.org>.
amit-jain commented on pull request #235:
URL: https://github.com/apache/jackrabbit-oak/pull/235#issuecomment-650903481
@neerajgrg The changes lgtm. But have you run the full suite of tests? I would expect that the testing is done for atleast eu_ireland, us standard and one other maybe singapore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] amit-jain commented on pull request #235: s3Connector changes for regions apart from aws default regions
Posted by GitBox <gi...@apache.org>.
amit-jain commented on pull request #235:
URL: https://github.com/apache/jackrabbit-oak/pull/235#issuecomment-652200147
Don't need a PR for it, will merge from trunk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] neerajgrg commented on pull request #235: s3Connector changes for regions apart from aws default regions
Posted by GitBox <gi...@apache.org>.
neerajgrg commented on pull request #235:
URL: https://github.com/apache/jackrabbit-oak/pull/235#issuecomment-651086936
@amit-jain can you please direct me to jira dashboard where should i create this jira ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] neerajgrg commented on pull request #235: s3Connector changes for regions apart from aws default regions
Posted by GitBox <gi...@apache.org>.
neerajgrg commented on pull request #235:
URL: https://github.com/apache/jackrabbit-oak/pull/235#issuecomment-652164387
okay, have a raised a pull request on 1.22 - https://github.com/apache/jackrabbit-oak/pull/237 . @amit-jain please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] reschke commented on pull request #235: s3Connector changes for regions apart from aws default regions
Posted by GitBox <gi...@apache.org>.
reschke commented on pull request #235:
URL: https://github.com/apache/jackrabbit-oak/pull/235#issuecomment-651821744
1.22, not1.10 (1.10 is retired)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] amit-jain commented on pull request #235: s3Connector changes for regions apart from aws default regions
Posted by GitBox <gi...@apache.org>.
amit-jain commented on pull request #235:
URL: https://github.com/apache/jackrabbit-oak/pull/235#issuecomment-651567050
Patch committed. Thanks! @neerajgrg this PR can be closed now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org