You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/07/20 18:41:38 UTC
[jira] [Commented] (CB-7142) Support for restoring plugin
"preferences" in "restore" CLI command
[ https://issues.apache.org/jira/browse/CB-7142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067977#comment-14067977 ]
ASF GitHub Bot commented on CB-7142:
------------------------------------
GitHub user motorro opened a pull request:
https://github.com/apache/cordova-lib/pull/63
Maintain plugin preferencies
A fullfilled feature [CB-7142](https://issues.apache.org/jira/browse/CB-7142)
Supports:
* Maintaining plugin installation URL in config feature list to be able to restore with `cordova restore plugins`
* Maintaining plugin preferences in config feature list. Otherwize the plugin like [this](https://github.com/EddyVerbruggen/LaunchMyApp-PhoneGap-Plugin) fail to restore or be added after `cordova platform add` command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/motorro/cordova-lib maintain-plugin-preferencies
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/63.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #63
----
commit 4c5765404ed8714a5ea0f8d5e026d3280335405d
Author: motorro <mo...@gmail.com>
Date: 2014-07-16T01:43:36Z
Restoring plugin preferences and installation url from config.xml
commit 7492b0a3c6893dddba4790da8b1e103ce4672bc2
Author: motorro <mo...@gmail.com>
Date: 2014-07-19T01:24:12Z
Parsing features data
commit 0fd5f39baaa9d4fae1d8b6df841fcbba78e5d34f
Author: motorro <mo...@gmail.com>
Date: 2014-07-20T15:22:23Z
ConfigParser specs for getting feature id list and getting feature data
commit 83b5e4366f4d15f160133fe3d39627fbe189e83d
Author: motorro <mo...@gmail.com>
Date: 2014-07-20T15:49:26Z
Feature preferences are passed to plugman when installing plugins after platform add
commit 60b16840cf6bd8e49df38aa2439d9373da1127cc
Author: motorro <mo...@gmail.com>
Date: 2014-07-20T16:23:55Z
Restoring plugins along with their preferences
----
> Support for restoring plugin "preferences" in "restore" CLI command
> -------------------------------------------------------------------
>
> Key: CB-7142
> URL: https://issues.apache.org/jira/browse/CB-7142
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI, Plugman
> Affects Versions: 3.5.0
> Reporter: Nikolai Kotchetkov
> Labels: features
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Thanks for great improvement having the plugin list in config.xml!
> However it will be great if "preferences" passed to plugman as variables could be saved there to.
> Like:
> {noformat}
> <feature name="Custom URL scheme">
> <param name="id" value="nl.x-services.plugins.launchmyapp" />
> <param name="url" value="https://github.com/EddyVerbruggen/LaunchMyApp-PhoneGap-Plugin.git" />
> <preference name="URL_SCHEME" value="VERBOSE"/>
> </feature>
> {noformat}
> I've made a rather simple fix for that in [this commit|https://github.com/motorro/cordova-lib/commit/4c5765404ed8714a5ea0f8d5e026d3280335405d]
> The code also has a feature of setting and using a plugin URL to install.
> Two more things required:
> # To be able to specify preferences per plugin to avoid possible name conflict - that involves installing plugins one-by-one rather than in batch as far as I understand the 'plugin("add")'
> # Add support to reinstalling plugins with respect to preferences on platform add - did not dig the code yet.
> It would be nice if someone comment on the issue - am I right or missing something already done. Also I can fullfill the requirement myself and issue a pull request if the feature seems handy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)