You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "kezhenxu94 (via GitHub)" <gi...@apache.org> on 2023/08/31 09:39:41 UTC

[GitHub] [skywalking-java] kezhenxu94 commented on pull request #601: Support maven revision

kezhenxu94 commented on PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#issuecomment-1700705710

   > > > > This is never discussed. Why do you add this?
   > > > 
   > > > 
   > > > Unify the version management in the parent class, which is convenient for publishing and packaging without modifying a version file every time you publish
   > > 
   > > 
   > > Is this compatible with the maven-publish plugin as well as the Apache release procedure?
   > 
   > Compatible. In the past, `mvn versions:set -DnewVersion=9.1.0` may be used to modify the version number in batches. Now it is only used to modify one place in the pom file. If you use the command, you can use `-Drevision=9.1.0` to modify, eg: `mvnd clean package -Dmaven.test.skip=true -Drevision=8.16.12 -Pall`
   
   Check the full steps about how to do the release, and verify the changes in this PR is OK in those process
   
   https://github.com/apache/skywalking/blob/1256f7059df3affd73c27d1b17a3cf8d7ea6efff/docs/en/guides/How-to-release.md?plain=1#L48
   
   If so I'm glad to approve the changes so that we don't have to change hundreds of lines in every release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org