You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/01/10 10:29:01 UTC
Re: Review Request 69337: Garbage collected disappeared resource
providers from master state.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69337/
-----------------------------------------------------------
(Updated Jan. 10, 2019, 11:29 a.m.)
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Changes
-------
Consolidated RP GC in block only executed in RP info is received.
Bugs: MESOS-9384
https://issues.apache.org/jira/browse/MESOS-9384
Repository: mesos
Description
-------
The master previously kept information on resource providers
indefinitely. This was confusing to API users who saw resource
providers reported which where not present anymore, and also made it
harder to derive actual cluster state.
With this patch we remove resource providers not reported by the agent
from master state. We still need to update the agent to not report
removed resource providers in a follow-up patch.
Diffs (updated)
-----
src/master/master.cpp 49b6e5c7d257bd9304215d47da13c9406c723cd8
src/messages/messages.proto 41e6a8a2eab0ae7c2878c1d3286c5dea0eb68ed7
Diff: https://reviews.apache.org/r/69337/diff/4/
Changes: https://reviews.apache.org/r/69337/diff/3-4/
Testing
-------
`make check`
Thanks,
Benjamin Bannier