You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2019/05/21 06:36:50 UTC
[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13387
Change subject: hms: allow skip validation in Hive Metastore Kudu plugin
......................................................................
hms: allow skip validation in Hive Metastore Kudu plugin
This commit adds a system env 'KUDU_SKIP_HMS_PLUGIN_VALIDATION' to
allow skip validation in the Hive Metastore Kudu plugin. This is useful
for testing purpose when the Kudu plugin is used when HMS integration
is actually disabled.
Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
1 file changed, 27 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/13387/1
--
To view, visit http://gerrit.cloudera.org:8080/13387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
Gerrit-Change-Number: 13387
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13387 )
Change subject: hms: allow skip validation in Hive Metastore Kudu plugin
......................................................................
Patch Set 2: Verified+1
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
File java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java:
http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@74
PS1, Line 74: static final String KUDU_TABLE_ID_KEY = "kudu.table_id";
> nit: maybe move this into the class header, that if the KUDU_SKIP_HMS_PLUGI
Done
http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@261
PS1, Line 261: }
> nit: is it possible to make this method static?
Done
http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@263
PS1, Line 263: masterAddresses.isEmpty(
> Seems we do this at least once here:
To align with the existing handling. I added the logic to not skip validation if it is set to 0.
--
To view, visit http://gerrit.cloudera.org:8080/13387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
Gerrit-Change-Number: 13387
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 24 May 2019 01:13:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13387 )
Change subject: hms: allow skip validation in Hive Metastore Kudu plugin
......................................................................
Patch Set 1: Code-Review+1
It can be in a follow up, but can you add a test that verifies this works?
--
To view, visit http://gerrit.cloudera.org:8080/13387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
Gerrit-Change-Number: 13387
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 21 May 2019 14:25:55 +0000
Gerrit-HasComments: No
[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13387 )
Change subject: hms: allow skip validation in Hive Metastore Kudu plugin
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
File java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java:
http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@261
PS1, Line 261: private boolean skipsValidation() {
nit: is it possible to make this method static?
http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@263
PS1, Line 263: skipValidation.isEmpty()
nit: I'm not an expert in Java and its conventions, but what if somebody sets KUDU_SKIP_HMS_PLUGIN_VALIDATION=0 ? Do we expect to skip validation in that case as well?
--
To view, visit http://gerrit.cloudera.org:8080/13387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
Gerrit-Change-Number: 13387
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 21 May 2019 18:56:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13387 )
Change subject: hms: allow skip validation in Hive Metastore Kudu plugin
......................................................................
Patch Set 1: Verified+1
Unrelated flaky test.
--
To view, visit http://gerrit.cloudera.org:8080/13387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
Gerrit-Change-Number: 13387
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 21 May 2019 18:15:11 +0000
Gerrit-HasComments: No
[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13387 )
Change subject: hms: allow skip validation in Hive Metastore Kudu plugin
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
File java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java:
http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@74
PS1, Line 74: // System env to track if the HMS plugin validation should be skipped.
nit: maybe move this into the class header, that if the KUDU_SKIP_HMS_PLUGIN_VALIDATION is set (to 0? nonzero? anything?), the plugin will skip all validation.
http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@263
PS1, Line 263: skipValidation.isEmpty()
> nit: I'm not an expert in Java and its conventions, but what if somebody se
Seems we do this at least once here:
https://github.com/apache/kudu/blob/c550fe8f55ee0a4c6838d246e00e541ef4cff460/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/ResultReporter.java#L154
I agree it'd be more intuitive, though I don't feel particularly strongly about it.
--
To view, visit http://gerrit.cloudera.org:8080/13387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
Gerrit-Change-Number: 13387
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 21 May 2019 19:14:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has removed a vote on this change.
Change subject: hms: allow skip validation in Hive Metastore Kudu plugin
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
Gerrit-Change-Number: 13387
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13387 )
Change subject: hms: allow skip validation in Hive Metastore Kudu plugin
......................................................................
hms: allow skip validation in Hive Metastore Kudu plugin
This commit adds a system env 'KUDU_SKIP_HMS_PLUGIN_VALIDATION' to
allow skip validation in the Hive Metastore Kudu plugin. This is useful
for testing purpose when the Kudu plugin is used when HMS integration
is actually disabled.
Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
Reviewed-on: http://gerrit.cloudera.org:8080/13387
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
1 file changed, 33 insertions(+), 2 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Hao Hao: Verified
Alexey Serbin: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/13387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
Gerrit-Change-Number: 13387
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13387 )
Change subject: hms: allow skip validation in Hive Metastore Kudu plugin
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
Gerrit-Change-Number: 13387
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 24 May 2019 01:09:25 +0000
Gerrit-HasComments: No
[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13387 )
Change subject: hms: allow skip validation in Hive Metastore Kudu plugin
......................................................................
Patch Set 2:
Unrelated test failure.
--
To view, visit http://gerrit.cloudera.org:8080/13387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
Gerrit-Change-Number: 13387
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 24 May 2019 01:14:16 +0000
Gerrit-HasComments: No
[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13387 )
Change subject: hms: allow skip validation in Hive Metastore Kudu plugin
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
Gerrit-Change-Number: 13387
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 24 May 2019 01:15:40 +0000
Gerrit-HasComments: No
[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13387
to look at the new patch set (#2).
Change subject: hms: allow skip validation in Hive Metastore Kudu plugin
......................................................................
hms: allow skip validation in Hive Metastore Kudu plugin
This commit adds a system env 'KUDU_SKIP_HMS_PLUGIN_VALIDATION' to
allow skip validation in the Hive Metastore Kudu plugin. This is useful
for testing purpose when the Kudu plugin is used when HMS integration
is actually disabled.
Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
1 file changed, 33 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/13387/2
--
To view, visit http://gerrit.cloudera.org:8080/13387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
Gerrit-Change-Number: 13387
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13387 )
Change subject: hms: allow skip validation in Hive Metastore Kudu plugin
......................................................................
Patch Set 1:
> It can be in a follow up, but can you add a test that verifies this
> works?
Sure, I will add the test in a follow up.
--
To view, visit http://gerrit.cloudera.org:8080/13387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
Gerrit-Change-Number: 13387
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 21 May 2019 18:16:06 +0000
Gerrit-HasComments: No
[kudu-CR] hms: allow skip validation in Hive Metastore Kudu plugin
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has removed a vote on this change.
Change subject: hms: allow skip validation in Hive Metastore Kudu plugin
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b
Gerrit-Change-Number: 13387
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)