You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/02/16 02:37:07 UTC

[GitHub] [rocketmq] Erik1288 commented on pull request #3848: [ISSUE #3831] Swapping mapped-byte-buffer to save memory on a system with extra-large disks.

Erik1288 commented on pull request #3848:
URL: https://github.com/apache/rocketmq/pull/3848#issuecomment-1041033566


   Thanks for your comments.
   
   > More suggested comments:
   > 
   > 1. Add some comments for interface Swappable, it's difficult to understand the specific meaning of `swapMap` and `cleanSwappedMap` directly.
   
   Re: Sure, more meaningful comments will be added.
   
   > 2. Add unit tests for this PR, and the implementations of `Swappable`.
   
   Re: Unit-test and Implementation were pushed but not be called.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org