You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/17 12:54:35 UTC

[GitHub] [flink] dawidwys commented on issue #10605: [FLINK-15168][table-planner] Fix physical indices computing.

dawidwys commented on issue #10605: [FLINK-15168][table-planner] Fix physical indices computing. 
URL: https://github.com/apache/flink/pull/10605#issuecomment-566529663
 
 
   cc @wuchong @twalthr 
   
   This PR has still one problem that `TableSourceITCase#testLegacyDecimalSourceUsingStreamTableSource` fails because in blink planner a legacy decimal type is converted to DECIMAL(38, 10) when going through RelDataType. Do you have any ideas how to approach this problem?
   
   We might also face that if somebody uses an old TableSource that still uses `getReturnType` with DDL instead of `getProducedDataType`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services