[GitHub] [ignite] ivandasch commented on a diff in pull request #10737: IGNITE-15629 Cache indexes force rebuild command implemented

["ivandasch (via GitHub)" <gi...@apache.org>]

ivandasch commented on code in PR #10737:
URL: https://github.com/apache/ignite/pull/10737#discussion_r1209814734


##########
modules/core/src/main/java/org/apache/ignite/internal/management/cache/CacheIndexesRebuildStatusCommand.java:
##########
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.management.cache;
+
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+import java.util.function.Consumer;
+import org.apache.ignite.internal.management.api.ComputeCommand;
+import org.apache.ignite.internal.util.typedef.T3;
+import org.apache.ignite.internal.visor.cache.index.IndexRebuildStatusInfoContainer;
+import org.apache.ignite.internal.visor.cache.index.IndexRebuildStatusTask;
+
+/** */
+public class CacheIndexesRebuildStatusCommand
+    implements ComputeCommand<CacheIndexesRebuildStatusCommandArg, Map<UUID, Set<IndexRebuildStatusInfoContainer>>> {
+    /** {@inheritDoc} */
+    @Override public String description() {
+        return "List all indexes that have index rebuild in progress";
+    }
+
+    /** {@inheritDoc} */
+    @Override public Class<CacheIndexesRebuildStatusCommandArg> argClass() {
+        return CacheIndexesRebuildStatusCommandArg.class;
+    }
+
+    /** {@inheritDoc} */
+    @Override public Class<IndexRebuildStatusTask> taskClass() {
+        return IndexRebuildStatusTask.class;
+    }
+
+    /** {@inheritDoc} */
+    @Override public Collection<UUID> nodes(Map<UUID, T3<Boolean, Object, Long>> nodes, CacheIndexesRebuildStatusCommandArg arg) {
+        return arg.nodeId() != null
+            ? Collections.singleton(arg.nodeId())
+            : nodes.keySet();
+    }
+
+    /** {@inheritDoc} */
+    @Override public void printResult(
+        CacheIndexesRebuildStatusCommandArg arg,
+        Map<UUID, Set<IndexRebuildStatusInfoContainer>> res,
+        Consumer<String> printer
+    ) {
+        if (!res.isEmpty())
+            printer.accept("Caches that have index rebuilding in progress:");
+        else {

Review Comment:
   It seems, that this code can be simflified:
   ```
   if (res.isEmpty()) {
       printer.accept("There are no caches that have index rebuilding in progress.");
       printer.accept("");
       return
   }
   
   printer.accept("Caches that have index rebuilding in progress:");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org