You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dennis Lundberg (JIRA)" <ji...@codehaus.org> on 2007/01/15 01:02:40 UTC
[jira] Created: (MPCHANGES-33) Make it possible to configure the
location of the changes.xml file
Make it possible to configure the location of the changes.xml file
------------------------------------------------------------------
Key: MPCHANGES-33
URL: http://jira.codehaus.org/browse/MPCHANGES-33
Project: maven-changes-plugin
Issue Type: New Feature
Affects Versions: 1.7
Reporter: Dennis Lundberg
Fix For: 1.7.1
Attachments: MPCHANGES-33.patch
It is useful for people that are in a transition from Maven 1 to Maven 2 to be able to move the changes.xml file to another location that the default one. The attached patch introduces a new property "maven.changes.file" that can be used to configure the location of the file. The default value is the same as what has been used in the previous versions.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MPCHANGES-33) Make it possible to configure the
location of the changes.xml file
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPCHANGES-33?page=comments#action_84995 ]
Dennis Lundberg commented on MPCHANGES-33:
------------------------------------------
It would be nice if someone could review the patch. I can take care of committing it, if it passes the review.
> Make it possible to configure the location of the changes.xml file
> ------------------------------------------------------------------
>
> Key: MPCHANGES-33
> URL: http://jira.codehaus.org/browse/MPCHANGES-33
> Project: maven-changes-plugin
> Issue Type: New Feature
> Affects Versions: 1.7
> Reporter: Dennis Lundberg
> Fix For: 1.7.1
>
> Attachments: MPCHANGES-33.patch
>
>
> It is useful for people that are in a transition from Maven 1 to Maven 2 to be able to move the changes.xml file to another location that the default one. The attached patch introduces a new property "maven.changes.file" that can be used to configure the location of the file. The default value is the same as what has been used in the previous versions.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MPCHANGES-33) Make it possible to configure the
location of the changes.xml file
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPCHANGES-33?page=comments#action_85043 ]
Arnaud Heritier commented on MPCHANGES-33:
------------------------------------------
Good catch !!! We have to update/release all these plugins.
We have to be able to put the changes.xml somewhere else because in maven 2, the directory (maven.docs.src) must contains only xdocs files (there's one directory per file type). It's the same problem for the navigation.xml
> Make it possible to configure the location of the changes.xml file
> ------------------------------------------------------------------
>
> Key: MPCHANGES-33
> URL: http://jira.codehaus.org/browse/MPCHANGES-33
> Project: maven-changes-plugin
> Issue Type: New Feature
> Affects Versions: 1.7
> Reporter: Dennis Lundberg
> Fix For: 1.7.1
>
> Attachments: MPCHANGES-33.patch
>
>
> It is useful for people that are in a transition from Maven 1 to Maven 2 to be able to move the changes.xml file to another location that the default one. The attached patch introduces a new property "maven.changes.file" that can be used to configure the location of the file. The default value is the same as what has been used in the previous versions.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MPCHANGES-33) Make it possible to configure the
location of the changes.xml file
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPCHANGES-33?page=comments#action_85024 ]
Lukas Theussl commented on MPCHANGES-33:
----------------------------------------
Be careful: changes.xml is used hard-coded in at least the following plugins: announcement, changelog, multichanges, scm and xdoc. In particular, I recently fixed the related MPSCM-86. I think the location of the file should be ${maven.docs.src} and only the filename should be configurable. WDYT?
> Make it possible to configure the location of the changes.xml file
> ------------------------------------------------------------------
>
> Key: MPCHANGES-33
> URL: http://jira.codehaus.org/browse/MPCHANGES-33
> Project: maven-changes-plugin
> Issue Type: New Feature
> Affects Versions: 1.7
> Reporter: Dennis Lundberg
> Fix For: 1.7.1
>
> Attachments: MPCHANGES-33.patch
>
>
> It is useful for people that are in a transition from Maven 1 to Maven 2 to be able to move the changes.xml file to another location that the default one. The attached patch introduces a new property "maven.changes.file" that can be used to configure the location of the file. The default value is the same as what has been used in the previous versions.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MPCHANGES-33) Make it possible to configure the
location of the changes.xml file
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPCHANGES-33?page=comments#action_84998 ]
Arnaud Heritier commented on MPCHANGES-33:
------------------------------------------
It's good. Go for it. Thx.
> Make it possible to configure the location of the changes.xml file
> ------------------------------------------------------------------
>
> Key: MPCHANGES-33
> URL: http://jira.codehaus.org/browse/MPCHANGES-33
> Project: maven-changes-plugin
> Issue Type: New Feature
> Affects Versions: 1.7
> Reporter: Dennis Lundberg
> Fix For: 1.7.1
>
> Attachments: MPCHANGES-33.patch
>
>
> It is useful for people that are in a transition from Maven 1 to Maven 2 to be able to move the changes.xml file to another location that the default one. The attached patch introduces a new property "maven.changes.file" that can be used to configure the location of the file. The default value is the same as what has been used in the previous versions.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MPCHANGES-33) Make it possible to configure the
location of the changes.xml file
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPCHANGES-33?page=comments#action_85111 ]
Arnaud Heritier commented on MPCHANGES-33:
------------------------------------------
Yes, the name of the property you proposed is fine for me.
You can use this issue in others plugins (for the issue # in the changes file).
You can also add on these plugins a constraint like :
{code:xml}
<!-- fake test because the assert:assertPluginAvailable tag is avalaible in the maven-plugin-plugin 1.7 and newer. Thus maven will break if it's not present. -->
<assert:assertPluginAvailable groupId="maven" artifactId="maven-plugin-plugin" minRelease="1.7" neededBy="${plugin.artifactId}"/>
<assert:assertPluginAvailable groupId="maven" artifactId="maven-changes-plugin" minRelease="1.7.1" neededBy="${plugin.artifactId}"/>
{code}
> Make it possible to configure the location of the changes.xml file
> ------------------------------------------------------------------
>
> Key: MPCHANGES-33
> URL: http://jira.codehaus.org/browse/MPCHANGES-33
> Project: maven-changes-plugin
> Issue Type: New Feature
> Affects Versions: 1.7
> Reporter: Dennis Lundberg
> Fix For: 1.7.1
>
> Attachments: MPCHANGES-33.patch
>
>
> It is useful for people that are in a transition from Maven 1 to Maven 2 to be able to move the changes.xml file to another location that the default one. The attached patch introduces a new property "maven.changes.file" that can be used to configure the location of the file. The default value is the same as what has been used in the previous versions.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MPCHANGES-33) Make it possible to configure the
location of the changes.xml file
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPCHANGES-33?page=comments#action_85106 ]
Dennis Lundberg commented on MPCHANGES-33:
------------------------------------------
I also think that we need to make this configurable in all plugins. It was pretty straight forward for the changes plugin. I'll look at creating patches for the other ones as well. A quick search in the plugins tree revealed the same plugins that Lukas mentioned.
We should use the same property for all plugins. Is the name "maven.changes.file" that I used in my patch a good one?
Should I create one issue for each of the affected plugins and link those issues to this one as being related?
> Make it possible to configure the location of the changes.xml file
> ------------------------------------------------------------------
>
> Key: MPCHANGES-33
> URL: http://jira.codehaus.org/browse/MPCHANGES-33
> Project: maven-changes-plugin
> Issue Type: New Feature
> Affects Versions: 1.7
> Reporter: Dennis Lundberg
> Fix For: 1.7.1
>
> Attachments: MPCHANGES-33.patch
>
>
> It is useful for people that are in a transition from Maven 1 to Maven 2 to be able to move the changes.xml file to another location that the default one. The attached patch introduces a new property "maven.changes.file" that can be used to configure the location of the file. The default value is the same as what has been used in the previous versions.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira