You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2013/02/10 16:25:19 UTC

[Bug 54541] New: [PATCH] Add support for cropped images in Slide.draw()

https://issues.apache.org/bugzilla/show_bug.cgi?id=54541

            Bug ID: 54541
           Summary: [PATCH] Add support for cropped images in Slide.draw()
           Product: POI
           Version: 3.9
          Hardware: Macintosh
                OS: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P2
         Component: HSLF
          Assignee: dev@poi.apache.org
          Reporter: djboulia@gmail.com
    Classification: Unclassified

Created attachment 29936
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29936&action=edit
BLIP cropping patch file

The BLIP properties for cropping images aren't used in the current draw()
method for Slide.  This patch implements cropping and includes a .ppt test file
that demonstrates the issues for cropped images.

This support is also missing from ooxml... I have that patch and will submit
separately.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 54541] [PATCH] Add support for cropped images in Slide.draw()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54541

Andreas Beeker <an...@gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Andreas Beeker <an...@gmx.de> ---
Thank you for the patch - applied with r1648335
Similar to #54542, I've used clipping instead of sub-imaging.
the extended test image reveals the lack of rotation support in group shapes.
I've already tried to use the same drawing logic as in XSLF (instead of
ShapePainter & Co.), but somehow rotated groups have swapped anchors fields for
certain rotation angles ... so only applying the patch for the existing drawing
logic.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 54541] [PATCH] Add support for cropped images in Slide.draw()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54541

Cédric Walter <ce...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #1 from Cédric Walter <ce...@gmail.com> ---
Hi

Thanks for the patch, could you try to also submit as patch also some unit
tests in org.apache.poi.hslf.model.TestPicture

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org