You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "JinyuChen97 (via GitHub)" <gi...@apache.org> on 2026/04/07 13:12:32 UTC
[PR] registering common Camel types used in onException for refle… [camel-quarkus]
JinyuChen97 opened a new pull request, #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505
fixes #7608
Found several common Camel exceptions that are frequently used in onException() handlers across multiple extensions. These are now registered centrally in camel-quarkus-core to avoid duplication and prevent ClassNotFoundException in native mode.
1. ExchangeTimedOutException
2. CamelAuthorizationException
3. CamelExecutionException
4. NoSuchEndpointException
5. ThrottlerRejectedExecutionException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4222084629
@aldettinger is this good to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4223242306
@JinyuChen97 It's right, things were mixed up on my machine. Sorry, for the noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4206597624
There is a question whether `integration-tests/netty` is the right place for such a test ? Maybe something ala `foundation/on-exception` would be better ?
It would be good to have other advice here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4222297565
Not sure yet.
What about `src/main/java/org/apache/camel/quarkus/eip/it/EipRoutes.java` with `@RegisterForReflection(targets = ThrottlerRejectedExecutionException.class)` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "JinyuChen97 (via GitHub)" <gi...@apache.org>.
JinyuChen97 commented on code in PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#discussion_r3050247175
##########
extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelNativeImageProcessor.java:
##########
@@ -159,6 +159,20 @@ void camelServices(
}
+ /**
+ * Register common Camel exception types for reflection.
+ */
+ @BuildStep
+ ReflectiveClassBuildItem registerCommonExceptions() {
+ return ReflectiveClassBuildItem.builder(
+ "org.apache.camel.ExchangeTimedOutException",
+ "org.apache.camel.CamelAuthorizationException",
+ "org.apache.camel.CamelExecutionException",
+ "org.apache.camel.NoSuchEndpointException",
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#discussion_r3045911541
##########
integration-tests/netty/src/main/java/org/apache/camel/quarkus/component/netty/tcp/NettyTcpResource.java:
##########
@@ -146,6 +146,14 @@ public void process(Exchange exchange) throws Exception {
mockEndpoint.assertIsSatisfied(5000L);
}
+ @Path("/async/delayed")
+ @POST
+ public String sendNettyTcpMessageWithAsyncDelayed(String message) {
Review Comment:
It this test in scope for ticket #7608 ? Or do we need this test to prove that `onException` common camel types are registered ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "JinyuChen97 (via GitHub)" <gi...@apache.org>.
JinyuChen97 commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4215283729
> Well, I think `throwException` is supported as well. Alexandre Gallice ***@***.***> 于2026年4月9日周四 22:39写道:
> […](#)
> *aldettinger* left a comment ([apache/camel-quarkus#8505](https://github.com/apache/camel-quarkus/pull/8505)) <[#8505 (comment)](https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4215097555)> Yes, there are probably more, a general review is probably needed. And maybe we could have in other DSLs, like xml dsl. Concerning throwException, it might be out of scope of this pr, maybe it could be separated to another ticket. — Reply to this email directly, view it on GitHub <[#8505 (comment)](https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4215097555)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJQHOYOK4F3T6H4V6YLBG34U6YYTAVCNFSM6AAAAACXPN7BQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMJVGA4TONJVGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>
throwException(Class) is supported, but the way like throwException(new instance) seems not supported , please correct me if i'm wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#discussion_r3046184581
##########
extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelNativeImageProcessor.java:
##########
@@ -159,6 +159,20 @@ void camelServices(
}
+ /**
+ * Register common Camel exception types for reflection.
+ */
+ @BuildStep
+ ReflectiveClassBuildItem registerCommonExceptions() {
+ return ReflectiveClassBuildItem.builder(
+ "org.apache.camel.ExchangeTimedOutException",
+ "org.apache.camel.CamelAuthorizationException",
+ "org.apache.camel.CamelExecutionException",
+ "org.apache.camel.NoSuchEndpointException",
+ "org.apache.camel.processor.ThrottlerRejectedExecutionException")
+ .build();
Review Comment:
This conversation might be more in the scope of #97. It was [not possible to inspect routes at build time](https://github.com/apache/camel-quarkus/issues/97#issuecomment-559607115). Unless we have any clue that this limitation has changed, I would vote for focusing this pr strictly on #7608.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "JinyuChen97 (via GitHub)" <gi...@apache.org>.
JinyuChen97 commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4212942665
> > Sorry @JinyuChen97 , I merge the following PR and it could conflict with your changes.
> >
> > * [Auto-detect onException/doCatch/throwException exception classes for native reflection #8508](https://github.com/apache/camel-quarkus/pull/8508)
>
> Yeah I think #8508 mostly supersedes this. What we could do instead in this PR, is search the codebase for usages of:
>
> ExchangeTimedOutException CamelAuthorizationException CamelExecutionException ThrottlerRejectedExecutionException
>
> And remove any native reflection configuration and verify that the native tests continue to pass.
Verified exception class registration using onException test. All exceptions are now auto-registered by the code change from #8508. The onException test handlers were removed after verification.
Only found one manually registered exception 'CamelAuthorizationException' in ShiroProcessor.java, which has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "JinyuChen97 (via GitHub)" <gi...@apache.org>.
JinyuChen97 commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4214635872
> Don't we have more to cover like in `MllpRoutes.java` where we have `@RegisterForReflection(targets = MllpInvalidMessageException.class, fields = false) ` ? If yes, could it make sense to modify the prompt to spot those cases ?
oh yes, you are right, this exception is used by onException(class) pattern, so it can be removed as well.
I also found other exceptions annotated with @RegisterForReflection, but they are used by throwException(new xxxexception()) and they are not abled to be detected by the CamelNativeImageProcessor.
integration-tests/servlet/src/main/java/org/apache/camel/quarkus/component/servlet/CustomException.java
annotation: @RegisterForReflection
usage: throwException(new CustomException())
integration-test-groups/http/netty-http/src/main/java/org/apache/camel/quarkus/component/http/netty/NettyHttpRoutes.java
annotation: @RegisterForReflection(targets = IllegalStateException.class, serialization = true)
usage: throwException(new IllegalStateException("Forced exception"))
integration-tests-support/messaging/common/src/main/java/org/apache/camel/quarkus/component/messaging/it/MessagingCommonRoutes.java
annotation: @RegisterForReflection(targets = IllegalStateException.class, serialization = true)
usage: throw new IllegalStateException(...)
please suggest if you found more. And should we investigate the solution of adding throwException(new class) or leave them at the moment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "JinyuChen97 (via GitHub)" <gi...@apache.org>.
JinyuChen97 commented on code in PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#discussion_r3045964623
##########
integration-tests/netty/src/main/java/org/apache/camel/quarkus/component/netty/tcp/NettyTcpResource.java:
##########
@@ -146,6 +146,14 @@ public void process(Exchange exchange) throws Exception {
mockEndpoint.assertIsSatisfied(5000L);
}
+ @Path("/async/delayed")
+ @POST
+ public String sendNettyTcpMessageWithAsyncDelayed(String message) {
Review Comment:
oh yes, you are right, this issue only solve if the common camel exception class supported in native mode. I will remove this delay test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#discussion_r3046589074
##########
extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelNativeImageProcessor.java:
##########
@@ -159,6 +159,20 @@ void camelServices(
}
+ /**
+ * Register common Camel exception types for reflection.
+ */
+ @BuildStep
+ ReflectiveClassBuildItem registerCommonExceptions() {
+ return ReflectiveClassBuildItem.builder(
+ "org.apache.camel.ExchangeTimedOutException",
+ "org.apache.camel.CamelAuthorizationException",
+ "org.apache.camel.CamelExecutionException",
+ "org.apache.camel.NoSuchEndpointException",
+ "org.apache.camel.processor.ThrottlerRejectedExecutionException")
+ .build();
Review Comment:
Closing the discussion, feel welcome to re-open if needed. And many thanks for taking the time to look at camel-quarkus @zhfeng :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#discussion_r3046234235
##########
extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelNativeImageProcessor.java:
##########
@@ -159,6 +159,20 @@ void camelServices(
}
+ /**
+ * Register common Camel exception types for reflection.
+ */
+ @BuildStep
+ ReflectiveClassBuildItem registerCommonExceptions() {
+ return ReflectiveClassBuildItem.builder(
+ "org.apache.camel.ExchangeTimedOutException",
+ "org.apache.camel.CamelAuthorizationException",
+ "org.apache.camel.CamelExecutionException",
+ "org.apache.camel.NoSuchEndpointException",
+ "org.apache.camel.processor.ThrottlerRejectedExecutionException")
+ .build();
Review Comment:
Ha, I see there is already an issue
- https://github.com/apache/camel-quarkus/issues/7841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4214067772
Don't we have more to cover like in `MllpRoutes.java` where we have `@RegisterForReflection(targets = MllpInvalidMessageException.class, fields = false)
` ? If yes, could it make sense to modify the prompt to spot those cases ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4215848538
Yes, that could be the scope of another ticket. Thanks all for great collective work on this subject :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4215326930
Hmm, yeah, that could be the case. throwException(new instance) might not
match the bytecode pattern. Feel free to invesigate it further if you like.
JinyuChen97 ***@***.***> 于2026年4月9日周四 23:08写道:
> *JinyuChen97* left a comment (apache/camel-quarkus#8505)
> <https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4215283729>
>
> Well, I think throwException is supported as well. Alexandre Gallice *@*.
>
> *> 于2026年4月9日周四 22:39写道: … <#m_987960130342204388_> aldettinger left a
> comment (apache/camel-quarkus#8505
> <https://github.com/apache/camel-quarkus/pull/8505>) <#8505 (comment)
> <https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4215097555>>
> Yes, there are probably more, a general review is probably needed. And
> maybe we could have in other DSLs, like xml dsl. Concerning throwException,
> it might be out of scope of this pr, maybe it could be separated to another
> ticket. — Reply to this email directly, view it on GitHub <#8505 (comment)
> <https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4215097555>>,
> or unsubscribe
> https://github.com/notifications/unsubscribe-auth/AAJQHOYOK4F3T6H4V6YLBG34U6YYTAVCNFSM6AAAAACXPN7BQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMJVGA4TONJVGU
> <https://github.com/notifications/unsubscribe-auth/AAJQHOYOK4F3T6H4V6YLBG34U6YYTAVCNFSM6AAAAACXPN7BQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMJVGA4TONJVGU>
> . You are receiving this because you were mentioned.Message ID: @.*>
>
> throwException(Class) is supported, but the way like throwException(new
> instance) seems not supported , please correct me if i'm wrong.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4215283729>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJQHOZ2GA4MFDKPYJ5D5634U64GBAVCNFSM6AAAAACXPN7BQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMJVGI4DGNZSHE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "JinyuChen97 (via GitHub)" <gi...@apache.org>.
JinyuChen97 commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4222751693
> And a last one is `./integration-tests/main-yaml/src/main/java/org/apache/camel/quarkus/main/CustomException.java`.
>
> This one is also used to test `throwException` by class but not not `throwException` by instance... So maybe it is a candidate for removal ?
hmmm, I think I have removed it? (The main-yaml/CustomException in the change) it's the one used in yaml dsl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#discussion_r3045994002
##########
extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelNativeImageProcessor.java:
##########
@@ -159,6 +159,20 @@ void camelServices(
}
+ /**
+ * Register common Camel exception types for reflection.
+ */
+ @BuildStep
+ ReflectiveClassBuildItem registerCommonExceptions() {
+ return ReflectiveClassBuildItem.builder(
+ "org.apache.camel.ExchangeTimedOutException",
+ "org.apache.camel.CamelAuthorizationException",
+ "org.apache.camel.CamelExecutionException",
+ "org.apache.camel.NoSuchEndpointException",
+ "org.apache.camel.processor.ThrottlerRejectedExecutionException")
+ .build();
Review Comment:
Hmm, is there any way we can find the `onException` classes at the build time? if so, we can register them on demand and maybe work with the customer classes as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "JinyuChen97 (via GitHub)" <gi...@apache.org>.
JinyuChen97 commented on code in PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#discussion_r3046037033
##########
extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelNativeImageProcessor.java:
##########
@@ -159,6 +159,20 @@ void camelServices(
}
+ /**
+ * Register common Camel exception types for reflection.
+ */
+ @BuildStep
+ ReflectiveClassBuildItem registerCommonExceptions() {
+ return ReflectiveClassBuildItem.builder(
+ "org.apache.camel.ExchangeTimedOutException",
+ "org.apache.camel.CamelAuthorizationException",
+ "org.apache.camel.CamelExecutionException",
+ "org.apache.camel.NoSuchEndpointException",
+ "org.apache.camel.processor.ThrottlerRejectedExecutionException")
+ .build();
Review Comment:
Thanks for the suggestion! That's a great idea. I will try to investigate it with the way you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4212188036
Sorry @JinyuChen97 , I merge the following PR and it could conflict with your changes.
- https://github.com/apache/camel-quarkus/pull/8508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4215097555
Yes, there are probably more, a general review is probably needed. And maybe we could have in other DSLs, like xml dsl. Concerning `throwException`, it might be out of scope of this pr, maybe it could be separated to another ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger merged PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4212241689
> Sorry @JinyuChen97 , I merge the following PR and it could conflict with your changes.
>
> * [Auto-detect onException/doCatch/throwException exception classes for native reflection #8508](https://github.com/apache/camel-quarkus/pull/8508)
Yeah I think #8508 mostly supersedes this. What we could do instead in this PR, is search the codebase for usages of:
ExchangeTimedOutException
CamelAuthorizationException
CamelExecutionException
ThrottlerRejectedExecutionException
And remove any native reflection configuration and verify that the native tests continue to pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#discussion_r3045244704
##########
extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelNativeImageProcessor.java:
##########
@@ -159,6 +159,20 @@ void camelServices(
}
+ /**
+ * Register common Camel exception types for reflection.
+ */
+ @BuildStep
+ ReflectiveClassBuildItem registerCommonExceptions() {
+ return ReflectiveClassBuildItem.builder(
+ "org.apache.camel.ExchangeTimedOutException",
+ "org.apache.camel.CamelAuthorizationException",
+ "org.apache.camel.CamelExecutionException",
+ "org.apache.camel.NoSuchEndpointException",
Review Comment:
I think we can remove `NoSuchEndpointException`.
It'd be a bit weird (maybe invalid) to be catching that within a Camel route.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4222351871
> Not sure yet.
>
> What about `src/main/java/org/apache/camel/quarkus/eip/it/EipRoutes.java` with `@RegisterForReflection(targets = ThrottlerRejectedExecutionException.class)` ?
Seems that was taken care of in https://github.com/apache/camel-quarkus/commit/76f2ba2bf4f02683d67eb1447d9c801f9897db56.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4222648595
And a last one is `./integration-tests/main-yaml/src/main/java/org/apache/camel/quarkus/main/CustomException.java`.
This one is also used to test `throwException` by class but not not `throwException` by instance... So maybe it is a candidate for removal ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] registering common Camel types used in onException for refle… [camel-quarkus]
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #8505:
URL: https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4215237328
Well, I think `throwException` is supported as well.
Alexandre Gallice ***@***.***> 于2026年4月9日周四 22:39写道:
> *aldettinger* left a comment (apache/camel-quarkus#8505)
> <https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4215097555>
>
> Yes, there are probably more, a general review is probably needed. And
> maybe we could have in other DSLs, like xml dsl. Concerning throwException,
> it might be out of scope of this pr, maybe it could be separated to another
> ticket.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel-quarkus/pull/8505#issuecomment-4215097555>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJQHOYOK4F3T6H4V6YLBG34U6YYTAVCNFSM6AAAAACXPN7BQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMJVGA4TONJVGU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org