You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Benjamin Marwell (Jira)" <ji...@apache.org> on 2019/12/14 15:24:00 UTC
[jira] [Comment Edited] (MCHECKSTYLE-384) Incompatibility to
Checkstyle version >= 8.24
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16996322#comment-16996322 ]
Benjamin Marwell edited comment on MCHECKSTYLE-384 at 12/14/19 3:23 PM:
------------------------------------------------------------------------
If maven checkstyle plugin updated checkstyle, the use could either
* update hishe {{checkstyle.xml}} file
* use a lower dependency of puppycrawl checkstyle.
Here's a how to: [https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html]
Updating checker to a higher version would mean to update to a new make version. Sadly, checkstyle did not do that, although they have a breaking change. This should have been checkstyle 9.x, not 8.24.
was (Author: mampf86):
I do not think that you can blame the {{maven-checkstyle-plugin}}. If you update the checkstyle plugin, either
* update the {{checkstyle.xml}} file you use or
* use a lower dependency of puppycrawl checkstyle.
Here's a how to: [https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html]
* Also, the maven-checkstyle site says: "This version of the plugin uses Checkstyle 8.19 by default" – is this not true anymore?
So, that said, what do you expect from the maven plugin? I just did take a look in the source code. maven checkstyle plugin indeed uses {{<checkstyleVersion>8.19</checkstyleVersion>}} by default. That said, the problem you reported must come from a configuration you did yourself. Maybe you did declare a newer checkstyle version somewhere?
Can you please elaborate more details? Otherwise I'd say this is "not an issue".
> Incompatibility to Checkstyle version >= 8.24
> ----------------------------------------------
>
> Key: MCHECKSTYLE-384
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-384
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:check
> Affects Versions: 3.1.0
> Reporter: Martin
> Priority: Blocker
>
> The latest {{maven-checkstyle-plugin}} is incompatible to Checkstyle version 8.24 and newer. The check for "LineLength" was moved from "TreeWalker" to "Checker".
> For further details see "Breaking backward compatibility" under https://checkstyle.org/releasenotes.html#Release_8.24
>
> {code:none|title=Maven Console Output}
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project top-secrect: Failed during checkstyle configuration: LineLength is not allowed as a child in Checker -> [Help 1]
> [ERROR] ...
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)