[GitHub] hughhhh commented on a change in pull request #6905: Erase previously shown chart on error

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #6905: Erase previously shown chart on error
URL: https://github.com/apache/incubator-superset/pull/6905#discussion_r257902140
 
 

 ##########
 File path: superset/assets/src/chart/Chart.jsx
 ##########
 @@ -107,6 +107,14 @@ class Chart extends React.PureComponent {
     const containerStyles = isLoading ? { height, width } : null;
     const isFaded = refreshOverlayVisible && !errorMessage;
     this.renderContainerStartTime = Logger.getTimestamp();
+    if (chartStatus === 'failed') {
+      return (
+        <StackTraceMessage
 
 Review comment:
   I'd put this in a `renderStackTraceMessage()` above then just return that function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org