[jira] [Commented] (TOMAHAWK-1607) focus cannot locate targets inside UIData elements

["Werner Punz (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/TOMAHAWK-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527876#comment-13527876 ] 

Werner Punz commented on TOMAHAWK-1607:
---------------------------------------

Ideally we should use visitTree, but we cannot because we have to support JSF 1.2 with the component. Anyway thanks for the patch, I will integrate it into the sandbox component.

                
> focus cannot locate targets inside UIData elements
> --------------------------------------------------
>
>                 Key: TOMAHAWK-1607
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1607
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Focus
>    Affects Versions: 1.1.6
>            Reporter: Mike Kienenberger
>            Assignee: Mike Kienenberger
>         Attachments: ExtendedHtmlFocus.java
>
>
> focus cannot generate correct clientIds for targets inside UIData elements because UIComponent.findComponent() does not preserve row index information.
> I noticed this in my legacy 1.1.6 app, but I suspect after glancing at the latest Tomahawk 1.1.9 code that the problem still persists.
> However, I don't know how much focus is really used anymore -- it never made it out of the sandbox, and ajax makes doing much of this a lot easier now.
> I created a workaround for focus by reimplementing a local version of findComponent() in a custom focus subclass and this workaround will work, except in those cases where a parent component had customized findComponent() behavior which I will attach to this issue.
> A more modern solution would likely be to dump findComponent for invokeOnComponent which correctly sets the rowIndex.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira