[GitHub] [arrow] kou commented on a change in pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds

[GitBox <gi...@apache.org>]

kou commented on a change in pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#discussion_r542858526



##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2465,20 +2490,35 @@ macro(build_grpc)
   string(REPLACE ";" "|" GRPC_PREFIX_PATH_ALT_SEP "${GRPC_CMAKE_PREFIX}")
 
   set(GRPC_CMAKE_ARGS
+      -DBUILD_SHARED_LIBS=OFF
       -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
+      -DCMAKE_CXX_FLAGS=${GRPC_CMAKE_CXX_FLAGS}

Review comment:
       Can we use `EP_COMMON_CMAKE_ARGS` for `GRPC_CMAKE_ARGS`?
   
   It seems that https://github.com/grpc/grpc/issues/13856 has been fixed in gRPC 1.33.1 or later.

##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2411,7 +2432,11 @@ macro(build_grpc)
   set(
     GRPC_STATIC_LIBRARY_UPB
     "${GRPC_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}upb${CMAKE_STATIC_LIBRARY_SUFFIX}")
-  set(GRPC_CPP_PLUGIN "${GRPC_PREFIX}/bin/grpc_cpp_plugin")
+  if(MSVC)
+    set(GRPC_CPP_PLUGIN "${GRPC_PREFIX}/bin/grpc_cpp_plugin.exe")
+  else()
+    set(GRPC_CPP_PLUGIN "${GRPC_PREFIX}/bin/grpc_cpp_plugin")
+  endif()

Review comment:
       Can we use `CMAKE_EXECUTABLE_SUFFIX` here?
   https://cmake.org/cmake/help/latest/variable/CMAKE_EXECUTABLE_SUFFIX.html
   
   ```suggestion
     set(GRPC_CPP_PLUGIN "${GRPC_PREFIX}/bin/grpc_cpp_plugin${CMAKE_EXECUTABLE_SUFFIX}")
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org