You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/19 13:32:39 UTC
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #16107: [Chore](EditLog) refine error output on edit log
BiteTheDDDDt opened a new pull request, #16107:
URL: https://github.com/apache/doris/pull/16107
# Proposed changes
refine error output on edit log
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16107: [Chore](EditLog) refine error output on edit log
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #16107:
URL: https://github.com/apache/doris/pull/16107#issuecomment-1397237240
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.08 seconds
load time: 495 seconds
storage size: 17121968810 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230119161823_clickbench_pr_84268.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt closed pull request #16107: [Chore](EditLog) refine error output on edit log
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt closed pull request #16107: [Chore](EditLog) refine error output on edit log
URL: https://github.com/apache/doris/pull/16107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #16107: [Chore](EditLog) refine error output on edit log
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #16107:
URL: https://github.com/apache/doris/pull/16107#issuecomment-1398580613
> > Why remove e?
>
> It seems that there are only two `{}` in the previous string, does `e` have any special meaning here?
The last e will print the stack trace of the exception, which can help to debug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #16107: [Chore](EditLog) refine error output on edit log
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #16107:
URL: https://github.com/apache/doris/pull/16107#issuecomment-1397805185
Why remove e?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #16107: [Chore](EditLog) refine error output on edit log
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #16107:
URL: https://github.com/apache/doris/pull/16107#issuecomment-1397841958
> Why remove e?
It seems that there are only two `{}` in the previous string, does `e` have any special meaning here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16107: [Chore](EditLog) refine error output on edit log
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16107:
URL: https://github.com/apache/doris/pull/16107#issuecomment-1397170914
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #16107: [Chore](EditLog) refine error output on edit log
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #16107:
URL: https://github.com/apache/doris/pull/16107#discussion_r1089138657
##########
fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java:
##########
@@ -994,9 +994,10 @@ public static void loadJournal(Env env, JournalEntity journal) {
* log a warning here to debug when happens. This could happen to other meta
* like DB.
*/
- LOG.warn("[INCONSISTENT META] replay failed {}: {}", journal, e.getMessage(), e);
+ LOG.warn("[INCONSISTENT META] replay failed {}: {}", journal, e.getMessage());
} catch (Exception e) {
- LOG.error("Operation Type {}", opCode, e);
+ LOG.error("Operation Type {}: {}", opCode, e.getMessage());
+ e.printStackTrace();
Review Comment:
>
@ByteYue could you please submit a PR to add `-XX:-OmitStackTraceInFastThrow`? I think this is necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] ByteYue commented on a diff in pull request #16107: [Chore](EditLog) refine error output on edit log
Posted by "ByteYue (via GitHub)" <gi...@apache.org>.
ByteYue commented on code in PR #16107:
URL: https://github.com/apache/doris/pull/16107#discussion_r1086313255
##########
fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java:
##########
@@ -994,9 +994,10 @@ public static void loadJournal(Env env, JournalEntity journal) {
* log a warning here to debug when happens. This could happen to other meta
* like DB.
*/
- LOG.warn("[INCONSISTENT META] replay failed {}: {}", journal, e.getMessage(), e);
+ LOG.warn("[INCONSISTENT META] replay failed {}: {}", journal, e.getMessage());
} catch (Exception e) {
- LOG.error("Operation Type {}", opCode, e);
+ LOG.error("Operation Type {}: {}", opCode, e.getMessage());
+ e.printStackTrace();
Review Comment:
Using `printStackTrace` would print the error msg to the stdout, i think it wouldn't help us debug. We can just log e so it will return the whole stack. If you are worried about the `Fast Throw` optimization that jvm would do, you can add `-XX:-OmitStackTraceInFastThrow` in start-fe.sh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] ByteYue commented on a diff in pull request #16107: [Chore](EditLog) refine error output on edit log
Posted by "ByteYue (via GitHub)" <gi...@apache.org>.
ByteYue commented on code in PR #16107:
URL: https://github.com/apache/doris/pull/16107#discussion_r1089592796
##########
fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java:
##########
@@ -994,9 +994,10 @@ public static void loadJournal(Env env, JournalEntity journal) {
* log a warning here to debug when happens. This could happen to other meta
* like DB.
*/
- LOG.warn("[INCONSISTENT META] replay failed {}: {}", journal, e.getMessage(), e);
+ LOG.warn("[INCONSISTENT META] replay failed {}: {}", journal, e.getMessage());
} catch (Exception e) {
- LOG.error("Operation Type {}", opCode, e);
+ LOG.error("Operation Type {}: {}", opCode, e.getMessage());
+ e.printStackTrace();
Review Comment:
> >
>
> @ByteYue could you please submit a PR to add `-XX:-OmitStackTraceInFastThrow`? I think this is necessary
OK, on my way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org