You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/04/14 03:01:53 UTC

[GitHub] [accumulo] ctubbsii commented on a change in pull request #1586: Fix for #1578

ctubbsii commented on a change in pull request #1586: Fix for #1578
URL: https://github.com/apache/accumulo/pull/1586#discussion_r407834068
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/singletons/SingletonManager.java
 ##########
 @@ -161,7 +164,7 @@ public static synchronized void setMode(Mode mode) {
     }
 
     // do not change from server mode, its a terminal mode that can not be left once entered
-    if (SingletonManager.mode != Mode.SERVER) {
+    if (SingletonManager.mode != Mode.SERVER || mode == Mode.CLOSED) {
 
 Review comment:
   The comment above this line covers the left hand side, but doesn't explain the right hand side of this `||` expression. Should it say something about `always allow changing state to CLOSED`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services