You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2016/07/28 13:41:16 UTC
[GitHub] zeppelin pull request #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter pro...
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/1239
[HOTFIX][ZEPPELIN-1240] Removed interpreter properties are restored
### What is this PR for?
Fixing the bug that users cannot delete some interpreter settings from interpreter tab.
### What type of PR is it?
[Bug Fix | Hot Fix]
### Todos
* [x] - Changed `update` to `set`
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1240
### How should this be tested?
1. Make new interpreter via interpreter tab
1. remove some properties
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-1240
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1239.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1239
----
commit 8d225977fedf43f5e7d17c30450a299d0265bd74
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-07-28T13:38:41Z
Changed updateProperties to setProperties
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter properties...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1239
Thanks for the fix. Tested and LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter properties...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1239
I'll trigger the CI one more, and merge it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter pro...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul closed the pull request at:
https://github.com/apache/zeppelin/pull/1239
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter properties...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1239
@Leemoonsoo I fixed it. Review it, please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter properties...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1239
@Leemoonsoo @minahlee Could you please test it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter pro...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1239
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter properties...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1239
Tested, looks good to me. I have one question. Seems like the issue exists both in `master` and `branch-0.6` branch, will this patch be applicable to branch-0.6 or shall we create another PR targeting branch-0.6?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter pro...
Posted by jongyoul <gi...@git.apache.org>.
GitHub user jongyoul reopened a pull request:
https://github.com/apache/zeppelin/pull/1239
[HOTFIX][ZEPPELIN-1240] Removed interpreter properties are restored
### What is this PR for?
Fixing the bug that users cannot delete some interpreter settings from interpreter tab.
### What type of PR is it?
[Bug Fix | Hot Fix]
### Todos
* [x] - Changed `update` to `set`
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1240
### How should this be tested?
1. Make new interpreter via interpreter tab
1. remove some properties
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-1240
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1239.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1239
----
commit 8d225977fedf43f5e7d17c30450a299d0265bd74
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-07-28T13:38:41Z
Changed updateProperties to setProperties
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter properties...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1239
@jongyoul Thanks for the quick response! I will test out #1274 too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter properties...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1239
@minahlee Isn't it available to merge this PR into branch-0.6?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter properties...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1239
Rebased it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter properties...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1239
Confirm that bug is gone. @jongyoul Could you rebase before merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter properties...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1239
Looks great to me.
CI failure:
```
[INFO] Zeppelin: web Application .......................... FAILURE [02:13 min]
...
[INFO] Running 'grunt build --no-color' in /home/travis/build/apache/zeppelin/zeppelin-web
[INFO] Running "jscs:all" (jscs) task
[INFO] >> 32 files without code style errors.
[INFO]
[INFO] Running "jscs:test" (jscs) task
[INFO] >> 6 files without code style errors.
[INFO]
[INFO] Running "eslint:all" (eslint) task
[INFO] Warning: Cannot find module './utils' Use --force to continue.
[INFO]
[INFO] Aborted due to warnings.
[INFO]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter properties...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1239
@minahlee I've made a new PR for branch-0.6 #1274
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---