You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/05/11 00:27:28 UTC

Review Request 59164: Updated fetcher tests to reflect changed interfaces.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59164/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-7304
    https://issues.apache.org/jira/browse/MESOS-7304


Repository: mesos


Description
-------

There are two primary changes to the tests:
  * The arguments passed to the fetcher's methods no longer contain
    the Flags or SlaveID.  So a couple of the mock expectations need
    to be tweaked.
  * Flags are now passed into the fetcher at construction.  Some of
    the tests modify the flags after construction, so the order of
    operations needed to be flipped.


Diffs
-----

  src/tests/fetcher_cache_tests.cpp 3bd63ed0a66493829a82c542ad05ebe0f7828d1a 
  src/tests/fetcher_tests.cpp 27ea7244c713934ef5a721ec133804a006dcb26e 


Diff: https://reviews.apache.org/r/59164/diff/1/


Testing
-------

See last patch in chain.


Thanks,

Joseph Wu

Re: Review Request 59164: Updated fetcher tests to reflect changed interfaces.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59164/#review174665
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On May 11, 2017, 12:27 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59164/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 12:27 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7304
>     https://issues.apache.org/jira/browse/MESOS-7304
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There are two primary changes to the tests:
>   * The arguments passed to the fetcher's methods no longer contain
>     the Flags or SlaveID.  So a couple of the mock expectations need
>     to be tweaked.
>   * Flags are now passed into the fetcher at construction.  Some of
>     the tests modify the flags after construction, so the order of
>     operations needed to be flipped.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp 3bd63ed0a66493829a82c542ad05ebe0f7828d1a 
>   src/tests/fetcher_tests.cpp 27ea7244c713934ef5a721ec133804a006dcb26e 
> 
> 
> Diff: https://reviews.apache.org/r/59164/diff/1/
> 
> 
> Testing
> -------
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>