You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Johannes Zillmann (JIRA)" <ji...@apache.org> on 2008/01/30 19:37:34 UTC

[jira] Created: (PIG-81) inconsistent named methods in DataAtom

inconsistent named methods in DataAtom
--------------------------------------

                 Key: PIG-81
                 URL: https://issues.apache.org/jira/browse/PIG-81
             Project: Pig
          Issue Type: Improvement
          Components: data
            Reporter: Johannes Zillmann
            Priority: Trivial


The getters for the various typs in DataAtom are named in an inconsitently way.
There are f.e.
longVal()
numval()
strval()

Personally i would favor the style of the field names. (stringVal, doubleVal, etc.. instead of strVal, numVal).


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-81) inconsistent named methods in DataAtom

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564167#action_12564167 ] 

Alan Gates commented on PIG-81:
-------------------------------

I agree that the accessor methods don't follow any observable naming convention.  However, as part of the types work DataAtom is going away, to be replaced by java native objects (Integer, String, etc.) (see http://wiki.apache.org/pig/PigTypesFunctionalSpec and http://wiki.apache.org/pig/PigTypesDesign).  So let's not spend time changing the names.

> inconsistent named methods in DataAtom
> --------------------------------------
>
>                 Key: PIG-81
>                 URL: https://issues.apache.org/jira/browse/PIG-81
>             Project: Pig
>          Issue Type: Improvement
>          Components: data
>            Reporter: Johannes Zillmann
>            Priority: Trivial
>
> The getters for the various typs in DataAtom are named in an inconsitently way.
> There are f.e.
> longVal()
> numval()
> strval()
> Personally i would favor the style of the field names. (stringVal, doubleVal, etc.. instead of strVal, numVal).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (PIG-81) inconsistent named methods in DataAtom

Posted by "Johannes Zillmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johannes Zillmann closed PIG-81.
--------------------------------

    Resolution: Won't Fix

ok!

> inconsistent named methods in DataAtom
> --------------------------------------
>
>                 Key: PIG-81
>                 URL: https://issues.apache.org/jira/browse/PIG-81
>             Project: Pig
>          Issue Type: Improvement
>          Components: data
>            Reporter: Johannes Zillmann
>            Priority: Trivial
>
> The getters for the various typs in DataAtom are named in an inconsitently way.
> There are f.e.
> longVal()
> numval()
> strval()
> Personally i would favor the style of the field names. (stringVal, doubleVal, etc.. instead of strVal, numVal).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.